fuzz: Rework ConsumeScript #23408

1. 
   MarcoFalke commented at 11:26 am on November 1, 2021: member

   This should make it easier for the fuzz engine to explore multisig code paths. See discussion in #23105

   The downside is that all fuzz inputs that use ConsumeScript are now invalidated and need to be re-generated.

   Another downside may be that most multisig scripts from ConsumeScript are using likely not fully valid pubkeys.

2. fuzz: Rework ConsumeScript

   This should make it easier for the fuzz engine to explore multisig code
   paths. See discussion in https://github.com/bitcoin/bitcoin/issues/23105
   
   The downside is that all fuzz inputs that use ConsumeScript are now
   invalidated and need to be re-generated.
   
   Another downside may be that most multisig scripts from ConsumeScript are
   using likely not fully valid pubkeys.

   fa4baf0756
3. 
   MarcoFalke commented at 11:55 am on November 1, 2021: member

   It should be possible to test this by checking out the commit prior to d6492d4ed053e2b9088a9666dc55c7417c7d4c70 and then applying the commit of this pull request. Then a few minutes or hours of fuzzing should give an assert.
4. DrahtBot added the label Tests on Nov 1, 2021
5. 
   jamesob commented at 2:23 pm on November 1, 2021: member

   ACK https://github.com/bitcoin/bitcoin/pull/23408/commits/fa4baf0756c792630391ed456aaa15285ad6eb52

   Read through the code, but haven’t tested it yet. This is a good change; giving the fuzzer more hints about how to construct structurally-valid scripts will hopefully help explore more code-paths and, at the very least, should help save cycles.

6. 
   sipa commented at 3:23 pm on November 1, 2021: member

   Concept ACK
7. 
   darosior commented at 8:58 am on November 11, 2021: member

   Concept ACK
8. MarcoFalke merged this on Nov 15, 2021
9. MarcoFalke closed this on Nov 15, 2021

   ---

10. MarcoFalke deleted the branch on Nov 15, 2021
11. sidhujag referenced this in commit c4ff2e2987 on Nov 16, 2021
12. DrahtBot locked this on Nov 15, 2022

Contributors
MarcoFalke jamesob sipa darosior

Labels
Tests