doc: Fix Arch PKGBUILD #23436

ghost commented at 11:30 PM on November 3, 2021: none

fix Arch PKGBUILD link

DrahtBot added the label Docs on Nov 4, 2021

in doc/build-unix.md:329 in 3ad8554fea outdated

 325 | @@ -326,7 +326,7 @@ This example lists the steps necessary to setup and build a command line only, n
 326 |  Note:
 327 |  Enabling wallet support requires either compiling against a Berkeley DB newer than 4.8 (package `db`) using `--with-incompatible-bdb`,
 328 |  or building and depending on a local version of Berkeley DB 4.8. The readily available Arch Linux packages are currently built using
 329 | -`--with-incompatible-bdb` according to the [PKGBUILD](https://projects.archlinux.org/svntogit/community.git/tree/bitcoin/trunk/PKGBUILD).
 330 | +`--with-incompatible-bdb` according to the [PKGBUILD](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=bitcoin-git).

jonatack commented at 4:55 PM on November 4, 2021:

Concept ACK on fixing the link, which appears to be broken.

If the new link is the right one and I'm reading it correctly, line 12 seems to indicate that db4.8 is a dependency rather than --with-incompatible-bdb.

real-or-random commented at 11:52 AM on November 8, 2021:

This is wrong. The new link points to a PKGBUILD to the (semi-offical) Arch User Repository. The official PKGBUILD is here: https://github.com/archlinux/svntogit-community/blob/packages/bitcoin/trunk/PKGBUILD, see the "Source Files" link here: https://archlinux.org/packages/community/x86_64/bitcoin-daemon/

ghost commented at 9:05 PM on November 4, 2021: none

laanwj commented at 10:21 AM on November 8, 2021: member

Thanks for your contribution. Please change the PR title and commit message to summarize your change, "Update build-unix.md" says nothing. Maybe "doc: Fix Arch PKGBUILD link in build-unix.md".

in doc/build-unix.md:327 in 3ad8554fea outdated

 325 | @@ -326,7 +326,7 @@ This example lists the steps necessary to setup and build a command line only, n
 326 |  Note:
 327 |  Enabling wallet support requires either compiling against a Berkeley DB newer than 4.8 (package `db`) using `--with-incompatible-bdb`,

maflcko commented at 10:46 AM on November 8, 2021:

This should probably mention sqlite as well

unknown renamed this:
~~Update build-unix.md~~
doc: Fix Arch PKGBUILD
on Nov 8, 2021

DrahtBot commented at 5:52 AM on November 9, 2021: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#23470 (doc: consolidate legacy wallet documentation by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko commented at 7:36 AM on November 14, 2021: member

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

ghost commented at 11:35 PM on November 14, 2021: none

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

Thanks. should be better now.

refactor: use const reference for parents in `CTxMemPool::UpdateAncestorsOf` b425ce3f48

refactor: move `update_*` structs from txmempool.h to .cpp file

These helpers are exclusively used in txmempool.cpp, hence they
should also be moved there.

Can be reviewed with "--color-moved=dimmed-zebra".

34129d520d

unknown closed this on Nov 14, 2021

bitcoin locked this on Nov 11, 2025