The tests streams_tests/streams_buffered_file and streams_tests/streams_buffered_file_rand
did not use a the temporary directory provided by BasicTestingSetup, so it was not possible
to execute multiple of them in parallel. This fixes that.
To reproduce, run
parallel --halt now,fail=1 './src/test/test_bitcoin --run_test=streams_tests/streams_buffered_file_rand' -- ::: {1..1000}
This executes the test 1000 times, one job per CPU. It works on that commit but mergebase fails quickly.
The tests `streams_tests/streams_buffered_file` and `streams_tests/streams_buffered_file_rand`
did not use a the temporary directory provided by `BasicTestingSetup`, so it was not possible
to execute multiple of them in parallel. This fixes that.
To reproduce, run
```sh
parallel --halt now,fail=1 './src/test/test_bitcoin --run_test=streams_tests/streams_buffered_file_rand' -- ::: {1..1000}
```
This executes the test 1000 times, one job per CPU. It works on that commit but mergebase fails quickly.
Tested ACK a04350b86c14a8038117aa013952b4e2b5f91cb0
master branch:
$ parallel --halt now,fail=1 './src/test/test_bitcoin --run_test=streams_tests/streams_buffered_file_rand' -- ::: 1 2 3
...
Running 1 test case...
unknown location(0): fatal error: in "streams_tests/streams_buffered_file_rand": std::__1::ios_base::failure: CBufferedFile::Fill: end of file: unspecified iostream_category error
test/streams_tests.cpp(373): last checkpoint
*** 1 failure is detected in the test module "Bitcoin Core Test Suite"
parallel: This job failed:
./src/test/test_bitcoin --run_test=streams_tests/streams_buffered_file_rand -- 1
PR branch:
$ parallel --halt now,fail=1 './src/test/test_bitcoin --run_test=streams_tests/streams_buffered_file_rand' -- ::: 1 2 3
...
Running 1 test case...
*** No errors detected
Running 1 test case...
*** No errors detected
Running 1 test case...
*** No errors detected
Good catch!