doc: Mention that BerkeleyDB is for legacy wallet in build-unix #23446

1. 
   laanwj commented at 5:32 pm on November 5, 2021: member

   This updates build-unix for the descriptor wallet, and prepares for eventual legacy wallet deprecation.

   • Move ‘descriptor wallet’ dependencies above legacy wallet deps both for Debian and Fedora.
   • Explicitly mention ’legacy wallet’ where referring to the BerkeleyDB wallet. Shorten BerkeleyDB instruction to a single paragraph.
2. laanwj added the label Docs on Nov 5, 2021
3. doc: Mention that BerkeleyDB is for legacy wallet in build-unix

   This updates build-unix for the descriptor wallet, and prepares for
   eventual legacy wallet deprecation.
   
   - Move 'descriptor wallet' dependencies above legacy wallet deps both
   for Debian and Fedora.
   - Explicitly mention 'legacy wallet' where referring to the BerkeleyDB
   wallet. Shorten BerkeleyDB instruction to a single paragraph.

   7eb5b25e6e
4. laanwj force-pushed on Nov 5, 2021
5. 
   katesalazar commented at 9:51 pm on November 5, 2021: contributor

   Concept ACK and thank you very much.
6. 
   brunoerg commented at 10:30 pm on November 5, 2021: member

   Concept ACK
7. lsilva01 approved
8. 
   lsilva01 commented at 4:17 am on November 6, 2021: contributor

   ACK 7eb5b25
9. 
   theStack commented at 2:57 am on November 7, 2021: member

   Concept ACK
10. in doc/build-unix.md:92 in 7eb5b25e6e

     96-
     97 SQLite is required for the descriptor wallet:
     98 
     99     sudo apt install libsqlite3-dev
    100 
    101+Berkeley DB is required for the legacy wallet. Ubuntu and Debian have their own `libdb-dev` and `libdb++-dev` packages,
    

    ---

    ---

    

    hebasto commented at 5:50 pm on November 7, 2021:

    nit: s/“Ubuntu and Debian”/“Debian-based systems”/

    ---

    

    katesalazar commented at 6:12 pm on November 7, 2021:

    s/“Ubuntu and Debian”/“Debian, Ubuntu and other Debian-based systems”/
11. hebasto approved
12. 
    hebasto commented at 5:50 pm on November 7, 2021: member

    ACK 7eb5b25e6ec790577f84f48942c9e8791dec8697, I have reviewed the code and it looks OK, I agree it can be merged.
13. fanquake merged this on Nov 8, 2021
14. fanquake closed this on Nov 8, 2021

    ---

15. sidhujag referenced this in commit 93db5be169 on Nov 8, 2021
16. MarcoFalke referenced this in commit e09cf64c48 on Mar 17, 2022
17. fanquake referenced this in commit 33f946b376 on Mar 23, 2022
18. fanquake referenced this in commit d7fd6cc80a on Mar 23, 2022
19. fanquake referenced this in commit 7ac7198bbd on Mar 24, 2022
20. fanquake referenced this in commit 7d0e42abce on Mar 24, 2022
21. fanquake referenced this in commit 95cac21615 on Mar 25, 2022
22. fanquake referenced this in commit a2b56dcd1f on Mar 28, 2022
23. fanquake referenced this in commit f3e3563369 on Apr 6, 2022
24. DrahtBot locked this on Nov 8, 2022

Contributors
laanwj katesalazar brunoerg lsilva01 theStack hebasto

Labels
Docs