ci, qa: Adjust timeouts per test instead of global `--timeout-factor` #23476

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:211109-timeout changing 5 files +5 −5
  1. hebasto commented at 1:21 PM on November 9, 2021: member

    A timeout failure in a functional test could point at a flaw in the test itself, e.g., #23463 (comment)).

    Therefore, setting --timeout-factor globally can just hide such flaws.

    This PR drops non-default --timeout-factor in CI, and adjusts timeouts in three tests only.

  2. ci, qa: Adjust timeouts per test instead of global `--timeout-factor` 0174245870
  3. hebasto added the label Tests on Nov 9, 2021
  4. MarcoFalke commented at 1:29 PM on November 9, 2021: member

    Can you explain how a large timeout can hide something? If there is a bug that will result in a long timeout, it surely will result in a short timeout just the same?

    This will likely break the valgrind config, which is not run by CI here,

  5. hebasto commented at 2:00 PM on November 9, 2021: member

    @MarcoFalke

    This will likely break the valgrind config, which is not run by CI here,

    The TEST_RUNNER_TIMEOUT_FACTOR variable can be assigned with a proper value in 00_setup_env_native_valgrind.sh, no?

    Can you explain how a large timeout can hide something?

    From your comment:

    test_feefilter generates blocks and txs on node1 (without syncing with node0). Then node1 won't accept/request the txs (because it is still busy syncing the blocks). Thus the test fails (times out).

  6. MarcoFalke commented at 2:20 PM on November 9, 2021: member

    If node1 incorrectly rejects the tx, the test will time out regardless of the timeout factor. Increasing the factor can at best unhide something, not hide something.

  7. hebasto closed this on Nov 9, 2021

  8. DrahtBot locked this on Nov 9, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me