test: tidy up addrman unit tests #23492

1. 
   MarcoFalke commented at 10:43 am on November 12, 2021: member

   Fix two issues:

   • Remove unneeded code, which makes test harder to read and write
   • Fix wrong indentation, which breaks some editors
2. test: Remove unused CDataStream copy fab9264be5
3. style: Use 4 spaces for indentation, not 5

   The wrong indentation breaks editor workflows.
   
   Can be reviewed with --ignore-all-space

   0000edaba3
4. fanquake added the label Tests on Nov 12, 2021
5. brunoerg approved
6. 
   brunoerg commented at 11:18 am on November 12, 2021: member

   cr/tACK 0000edaba306487a750f5648438f3dc8de08127c
7. shaavan approved
8. 
   shaavan commented at 12:32 pm on November 12, 2021: contributor

   ACK 0000edaba306487a750f5648438f3dc8de08127c
9. 
   jnewbery commented at 12:39 pm on November 12, 2021: member

   Code review ACK 0000edaba306487a750f5648438f3dc8de08127c
10. MarcoFalke referenced this in commit c9dd5c8d6e on Nov 12, 2021
11. MarcoFalke closed this on Nov 12, 2021

    ---

12. MarcoFalke deleted the branch on Nov 12, 2021
13. MarcoFalke restored the branch on Nov 12, 2021
14. MarcoFalke deleted the branch on Nov 12, 2021
15. MarcoFalke restored the branch on Nov 12, 2021
16. MarcoFalke deleted the branch on Nov 12, 2021
17. sidhujag referenced this in commit cf03e2cb44 on Nov 12, 2021
18. DrahtBot locked this on Nov 12, 2022

Contributors
MarcoFalke brunoerg shaavan jnewbery

Labels
Tests