Block uneconomic UTXO creation #2351

pull petertodd wants to merge 2 commits into bitcoin:master from petertodd:block-uneconomic-utxo-creation changing 3 files +38 −3
  1. petertodd commented at 1:11 am on March 10, 2013: contributor

    Keeps the UTXO set from being bloated by the creation of outputs that will never be spent because doing so would cost more in fees than they are worth.

    Includes changes to the UI to ensure the user can’t create such outputs, as well as the transaction creation code to round off change if the change txout would itself be unspendable.

  2. Create COIN_DUST_RATIO and COIN_DUST constants
    Based on work by Jeff Garzik
    8f2f760c95
  3. Ignore output values too small to profitably spend
    Keeps the UTXO set from being bloated by the creation of outputs that
    will never be spent because doing so would cost more in fees than they
    are worth.
    
    Includes changes to the UI to ensure the user can't create such outputs,
    as well as the transaction creation code to round off change if the
    change txout would itself be unspendable.
    0df65da397
  4. BitcoinPullTester commented at 1:33 am on March 10, 2013: none
    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0df65da397f5b1927783f7a8dba2f69e1cfef3ff for binaries and test log.
  5. gavinandresen commented at 2:17 am on March 10, 2013: contributor

    Needs unit tests and a thorough test plan. If you want this to be pulled, you’ll also need a user-friendly discussion of what this changes and how it affects SatoshiDice, how it affects users who might already have coin dust in their wallets, etc.

    Or, in other words: writing the code is the easy part…

  6. petertodd commented at 2:29 am on March 10, 2013: contributor
    Oh, frankly I’m surprised you think the issue is settled enough to be writing that stuff at that stage; I wasn’t expecting this to be anywhere close to being pulled yet.
  7. gavinandresen commented at 2:36 am on March 10, 2013: contributor
    If it isn’t anywhere close to being pulled, why did you submit it? I don’t like “Pull Request As A Forum For Discussion” …
  8. gavinandresen commented at 2:37 am on March 10, 2013: contributor
    (oh, WHY I don’t like pull-request-as-a-forum-for-discussion: because it make my job harder, and wastes people time reviewing code that may never have a chance of being pulled)
  9. petertodd commented at 2:55 am on March 10, 2013: contributor
    Oh, I see you just want pull-reqs saved for code that has already had the initial discussion about it specifically done elsewhere; the pros and cons of the basic idea and varients have been discussed endlessly elsewhere.
  10. gavinandresen commented at 3:02 am on March 10, 2013: contributor
    Closing; please re-open when this is ready for pulling into mainline.
  11. gavinandresen closed this on Mar 10, 2013

  12. jgarzik commented at 1:36 am on April 9, 2013: contributor
    Recent data spam seems to make this worth revisiting, and re-opening.
  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-24 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me