policy: Treat taproot as always active #23512

1. 
   MarcoFalke commented at 9:36 am on November 15, 2021: member

   Now that taproot is active, it can be treated as if it was always active for policy for the next major release. This simplifies the code and changes two things:

   • Importing tr descriptors can be done before the chain is fully synced. This is fine, because the wallet will already generate tr descriptors by default (regardless of the taproot status) after commit 47fe7445e7f54aee10ec6dbc53f1db1adbeb43de.
   • Valid taproot spends won’t be rejected from the mempool before taproot is active. This is strictly speaking a bugfix after commit 47fe7445e7f54aee10ec6dbc53f1db1adbeb43de, since the wallet may generate taproot spends before the chain is fully synced. For example, a slow node or a purposefully offline node. Currently, the wallet needs the mempool to account for change. See #11887.

   A similar change was done for segwit v0 in #13120 .

   This effectively reverts commit c5ec0367d718544caa3a1578d6c730fc92ee4e94.

2. MarcoFalke force-pushed on Nov 15, 2021
3. DrahtBot added the label interfaces on Nov 15, 2021
4. DrahtBot added the label RPC/REST/ZMQ on Nov 15, 2021
5. DrahtBot added the label TX fees and policy on Nov 15, 2021
6. DrahtBot added the label Validation on Nov 15, 2021
7. DrahtBot added the label Wallet on Nov 15, 2021
8. MarcoFalke removed the label Wallet on Nov 15, 2021
9. MarcoFalke removed the label RPC/REST/ZMQ on Nov 15, 2021
10. MarcoFalke removed the label Validation on Nov 15, 2021
11. MarcoFalke removed the label interfaces on Nov 15, 2021
12. MarcoFalke force-pushed on Nov 15, 2021
13. 
    sipa commented at 4:41 pm on November 15, 2021: member

    Concept ACK
14. 
    DrahtBot commented at 5:44 am on November 16, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23536 (Enforce Taproot script flags whenever WITNESS is set by MarcoFalke)
    • #23308 (Update basic multisig test/docs to use multipath descriptor by mjdietzx)
    • #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)
    • #21702 (Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin)
    • #15719 (Wallet passive startup by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

15. policy: Treat taproot as always active fa3e0da06b
16. MarcoFalke force-pushed on Nov 16, 2021
17. MarcoFalke deleted a comment on Nov 16, 2021
18. 
    MarcoFalke commented at 7:23 am on November 16, 2021: member

    @achow101 Sorry, I accidentally deleted your comment. It was a comment on the docstring of Standard:

    This comment is hard to parse, and it doesn’t really explain each value in the enum. Could you please clarify?

    Thanks, I’ve force pushed a new docstring.

19. 
    mjdietzx commented at 5:09 pm on November 16, 2021: contributor

    Code Review ACK fa3e0da06b491b8c0fa2dbae37682a9112c9deb8
20. 
    achow101 commented at 5:33 pm on November 16, 2021: member

    ACK fa3e0da06b491b8c0fa2dbae37682a9112c9deb8
21. MarcoFalke added the label Review club on Nov 20, 2021
22. 
    sipa commented at 3:50 pm on November 22, 2021: member

    utACK fa3e0da06b491b8c0fa2dbae37682a9112c9deb8
23. 
    gruve-p commented at 11:31 am on November 24, 2021: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/23512/commits/fa3e0da06b491b8c0fa2dbae37682a9112c9deb8
24. in test/functional/feature_taproot.py:445 in fa3e0da06b

    441+# V23 means the major version 23.0 and any later version
    442+# NONE means no version
    443+Standard = Enum('Standard', 'ALL V23 NONE')
    444 
    445-def make_spender(comment, *, tap=None, witv0=False, script=None, pkh=None, p2sh=False, spk_mutate_pre_p2sh=None, failure=None, standard=True, err_msg=None, sigops_weight=0, need_vin_vout_mismatch=False, **kwargs):
    446+
    

    ---

    ---

    

    rajarshimaitra commented at 2:39 pm on November 24, 2021:

    This seems to be an extra line of space.

    ---

    

    MarcoFalke commented at 3:46 pm on November 24, 2021:

    According to pep-8, two lines are recommended.
25. 
    rajarshimaitra commented at 2:39 pm on November 24, 2021: contributor

    code review + tACK https://github.com/bitcoin/bitcoin/pull/23512/commits/fa3e0da06b491b8c0fa2dbae37682a9112c9deb8
26. 
    gunar commented at 7:18 pm on November 24, 2021: contributor

    Code Review + tACK fa3e0da06
27. MarcoFalke merged this on Nov 25, 2021
28. MarcoFalke closed this on Nov 25, 2021

    ---

29. MarcoFalke deleted the branch on Nov 25, 2021
30. sidhujag referenced this in commit 95074ec543 on Nov 25, 2021
31. fanquake referenced this in commit 23e8c702bc on Mar 11, 2022
32. DrahtBot locked this on Mar 6, 2023

Contributors
MarcoFalke sipa DrahtBot mjdietzx achow101 gruve-p rajarshimaitra gunar

Labels
TX fees and policy Review club