ci: Drop --failfast in functional tests on native Windows CI task #23513

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:211115-ff changing 1 files +1 −1

hebasto commented at 9:42 AM on November 15, 2021: member

As it was discussed in bitcoin/bitcoin#22980:

seeing all of the failed tests can give us a useful hint for debugging (was thinking about that while reviewing and testing bitcoin/bitcoin#23300).

There is a concern about such approach:

If there is a CI failure, it will be good to know the result as early as possible after opening the pull request.

But, OTOH:

the average amount of saved time for such an approach [using --failfast] is less significant than it could appear.
ci: Drop --failfast in functional tests on native Windows CI task 23c3dcb4e7
MarcoFalke commented at 10:00 AM on November 15, 2021: member

cr ACK 23c3dcb4e74b21c7a1f1bb334cb5547a6bf128f1 seems fine to give this a try

I haven't measured at how much time is saved or wasted, but it seems likely subjective anyway. This will save people from complaining about issue #23085. Also, it might help debugging.

Can be reverted any time, if it turns out this didn't help.
DrahtBot added the label Tests on Nov 15, 2021
MarcoFalke merged this on Nov 15, 2021
MarcoFalke closed this on Nov 15, 2021
katesalazar commented at 8:50 PM on November 15, 2021: contributor

Concept ACK, suggest not to enable back again.

IMO failfast is for developing on humble local setups and gives no real advantage used in CI.
sidhujag referenced this in commit c0d1f2121a on Nov 16, 2021
hebasto deleted the branch on Nov 16, 2021
DrahtBot locked this on Nov 17, 2022

Contributors

Labels

Linked (view graph)

#22980 qa: Ignore `--failfast` option of `test_runner.py` on Windows