test: Return the largest utxo in MiniWallet.get_utxo #23515

1. 
   MarcoFalke commented at 12:13 pm on November 15, 2021: member

   This is for consistency with the send_self_transfer method.

   Also, remove the feature that the change of the last transfer can be retrieved via get_utxo. This can trivially and clearer be achieved by simply passing the txid of the transfer.

   Also, this fixes the bug in feature_txindex_compatibility in current master after a silent merge conflict.

   Fixes #23514

2. test: Return the largest utxo in MiniWallet.get_utxo fa62207737
3. fanquake added the label Tests on Nov 15, 2021
4. MarcoFalke requested review from theStack on Nov 15, 2021
5. 
   MarcoFalke commented at 4:19 pm on November 15, 2021: member

   Going to merge this, but maybe someone donates a post-merge ack some day?
6. MarcoFalke merged this on Nov 15, 2021
7. MarcoFalke closed this on Nov 15, 2021

   ---

8. 
   Sjors commented at 4:29 pm on November 15, 2021: member

   Looks like @theStack and @mjdietzx last touched this, so perhaps they can check this change. See also #20385
9. MarcoFalke deleted the branch on Nov 15, 2021
10. 
    theStack commented at 4:58 pm on November 15, 2021: member

    Post-merge code-review ACK fa62207737657e76ba45d5bf826fc0ccac658df6 🪐

    Note that this changes the functionality of create_self_transfer slightly: before it would always sort the internal UTXOs first, now it would only do that if no utxo_to_spend is passed. I don’t think this is a problem though – actually it seems to be more logical to only sort if needed.

    Also checked that only one (out of 7) instance of .get_utxo() calls without parameters are expecting to get the change output, which is tackled in rpc_txoutproof.py by passing the txid.

11. sidhujag referenced this in commit 01f34f8f83 on Nov 16, 2021
12. DrahtBot locked this on Nov 15, 2022

Contributors
MarcoFalke Sjors theStack

Labels
Tests