Argument names of nInIn are not helpful.
doc: Pick better named args for MutableTransactionSignatureCreator #23525
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2111-docMutableTransactionSignatureCreator changing 3 files +9 −9-
MarcoFalke commented at 12:39 PM on November 16, 2021: member
-
fa54a40809
doc: Pick better named args for MutableTransactionSignatureCreator
Argument names of "nInIn" are not helpful.
- MarcoFalke added the label Docs on Nov 16, 2021
-
katesalazar commented at 12:57 PM on November 16, 2021: contributor
Concept ACK.
- shaavan approved
-
shaavan commented at 2:37 PM on November 16, 2021: contributor
ACK fa54a408096244ff83a3e60e5fb7bfa6aecabe6b
The variable names are now more understandable and follow snake_case naming convention, rather than camel case convention, which is in line with bitcoin’s naming convention. Similarly, direct initialization (
()) is replaced with direct list initialization ({}) for initializing member variables of theMutableTransactionSignatureCreatorclass.I have checked for clang-formatting for the changes introduced, and I found no formatting issues either.
- fanquake requested review from achow101 on Nov 17, 2021
-
DrahtBot commented at 4:33 AM on November 17, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22793 (Simplify BaseSignatureChecker virtual functions and GenericTransactionSignatureChecker constructors by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
achow101 commented at 5:13 AM on November 17, 2021: member
ACK fa54a408096244ff83a3e60e5fb7bfa6aecabe6b
- MarcoFalke merged this on Nov 17, 2021
- MarcoFalke closed this on Nov 17, 2021
- MarcoFalke deleted the branch on Nov 17, 2021
- sidhujag referenced this in commit 5b73331450 on Nov 17, 2021
- DrahtBot locked this on Nov 17, 2022
Contributors
Labels