Configure scripts are supposed to adhere to the POSIX shell language. The POSIX test builtin does not implement an == operator. Bash does, but not all systems have Bash installed as /bin/sh. In particular, many systems use the lighter-weight Dash as the default POSIX shell. Dash emits the following error when running configure:
./configure: 39065: test: xno: unexpected operator
This PR removes the Bashism and restores correct operation with POSIX-compliant shells like Dash.
Is there a way to turn the warning into an error? We use dash in the CI, but no one is going to read the logs to find those errors.
See https://cirrus-ci.com/task/5279449093505024?logs=ci#L1704
Options used to compile and link:
external signer = yes
multiprocess = no
with experimental syscall sandbox support = no
with libs = yes
with wallet = yes
with sqlite = yes
with bdb = yes
with gui / qt = yes
with qr = yes
with zmq = yes
./configure: 35955: test: xno: unexpected operator
with test = not building test_bitcoin because fuzzing is enabled
with fuzz = no
...
Is there a way to turn the warning into an error?
On my Gentoo system, because this particular mistake is so common, I have a post-configure check on all builds:
if fgrep -q -e ': unexpected operator' -e 'configure: line' "${T}/build.log" ; then
eerror 'Package exhibits symptoms of assuming /bin/sh is Bash!'
eerror 'Maybe setting CONFIG_SHELL=/bin/bash will work around it.'
die
fi
It's a brittle check, but it's helped me catch and fix at least a dozen Bashisms in various packages.
ACK cf7292597e18ffca06b0fbf8bcd545aec387e380.
Code review ACK cf7292597e18ffca06b0fbf8bcd545aec387e380
Obvious agree that it would be good if these kind of errors were actually fatal errors.