Add external signer taproot support #23578

1. 
   Sjors commented at 3:16 pm on November 23, 2021: member

   Builds on #22558 (merged on 2022-06-28).

   HWI 2.1.0 or newer is required to import and use taproot descriptors. Older versions will work, but won’t import a taproot descriptor.

   Tested with HWI 2.1.1:

   • Trezor T (firmware v2.5.1) on Signet: signs, change detection works
   • Ledger Nano S (firmware 2.1.0, Bitcoin app 2.0.6): signs, change detection works

   Only the most basic tr(key) descriptor is supported, script path spending is completely untested (if it works at all).

2. DrahtBot added the label Descriptors on Nov 23, 2021
3. DrahtBot added the label RPC/REST/ZMQ on Nov 23, 2021
4. DrahtBot added the label Wallet on Nov 23, 2021
5. 
   DrahtBot commented at 6:07 pm on November 23, 2021: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24313 (Improve display address handling for external signer by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. DrahtBot added the label Needs rebase on Dec 13, 2021
7. Sjors force-pushed on Dec 30, 2021
8. DrahtBot removed the label Needs rebase on Dec 30, 2021
9. DrahtBot added the label Needs rebase on Mar 4, 2022
10. 
    Sjors commented at 1:35 pm on May 10, 2022: member

    Rebased, but won’t work yet.
11. Sjors force-pushed on May 10, 2022
12. Sjors force-pushed on May 10, 2022
13. Sjors marked this as ready for review on May 10, 2022
14. 
    Sjors commented at 2:37 pm on May 10, 2022: member

    Updated the external signer code to also look for fingerprints in input.m_tap_bip32_paths, so now it works.
15. DrahtBot removed the label Needs rebase on May 10, 2022
16. DrahtBot added the label Needs rebase on May 18, 2022
17. Sjors force-pushed on May 20, 2022
18. DrahtBot removed the label Needs rebase on May 20, 2022
19. Sjors force-pushed on Jun 27, 2022
20. wallet: add taproot support to external signer 796b020c37
21. Sjors force-pushed on Jun 28, 2022
22. 
    Sjors commented at 3:16 pm on June 28, 2022: member

    Hooray, #22558 was merged, so this is now just one commit on top of master.
23. 
    jb55 commented at 3:34 pm on June 28, 2022: contributor

    utACK 796b020c37c793674f9d614d5d70fd1ed65f0938
24. 
    achow101 commented at 10:54 pm on October 25, 2022: member

    ACK 796b020c37c793674f9d614d5d70fd1ed65f0938
25. fanquake merged this on Oct 26, 2022
26. fanquake closed this on Oct 26, 2022

    ---

27. Sjors deleted the branch on Oct 26, 2022
28. sidhujag referenced this in commit b2fd8cd7be on Oct 27, 2022
29. bitcoin locked this on Oct 26, 2023

Contributors
Sjors DrahtBot jb55 achow101

Labels
Wallet RPC/REST/ZMQ Descriptors