test: Adding functional test for -maxuploadtarget with byte unit 'M' #23584

pull dougEfresh wants to merge 1 commits into bitcoin:master from dougEfresh:maxuploadtarget-functional-byteunit changing 3 files +30 −2

dougEfresh commented at 4:21 PM on November 24, 2021: contributor

Adding new functional test for -maxuploadtarget Same tests as in test/functional/feature_maxuploadtarget.py but with -maxuploadtarget=800M
dougEfresh force-pushed on Nov 24, 2021
DrahtBot added the label Tests on Nov 24, 2021
brunoerg commented at 11:15 PM on November 24, 2021: member

In feature_maxuploadtarget.py, it tests the maxuploadtarget with two values 800 and 1. See: https://github.com/bitcoin/bitcoin/blob/64059b78f59e45cc4200ca76d0af8c6dff8a20d4/test/functional/feature_maxuploadtarget.py#L144

I think the approach you took we would be testing -maxuploadtarget=1 twice when executing feature_maxuploadtarget_byteunit.py and feature_maxuploadtarget.py. Maybe, you can create another variable to it? And then, you can test 1M?
test: Adding functional test for -maxuploadtarget with byte unit 'M' d61013576c
dougEfresh force-pushed on Nov 25, 2021
dougEfresh commented at 9:23 AM on November 25, 2021: contributor

In feature_maxuploadtarget.py, it tests the maxuploadtarget with two values 800 and 1. See:

Updated to include 1M
luke-jr changes_requested
luke-jr commented at 10:22 PM on November 30, 2021: member

Prefer to keep it in the existing file
dougEfresh commented at 11:20 AM on December 2, 2021: contributor

Prefer to keep it in the existing file

Agreed. It was easier for me to open a new PR, closing this one, new PR #23648
dougEfresh closed this on Dec 2, 2021
dougEfresh deleted the branch on Dec 2, 2021
DrahtBot locked this on Dec 2, 2022

Contributors

Labels