I accidentally -torcontrol=1 today (instead of -listenonion=1) and was confused that it was accepted, as the argument needs to be host:port.
Expected outcome would be an error message and exiting.
For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.
Ok, so I was able to add a function successfully that can check if the given string is a valid <host>:<port> pair or not. The issue is that I cannot raise an error when the argument is wrongly passed when initializing bitcoind.
In fact, bitcoind is not raising an error for any invalid argument passed at initialization.
Expected outcome would be an error message and exiting.
Just a confirmation. When the ./src/bitcoind command is initially run with invalid parameters, do we expect an error message and exit? Or is it expected to occur later in the runtime of bitcoind?
git grep InitError might help you.
I see it not throwing the error because it is returning true here if it has no :
I can open a PR to change this to false but it would affect these files that use SplitHostPort in ./bitcoin/src
0./src/test/fuzz/string.cpp:87
1./src/test/netbase_tests.cpp:89
2./src/util/strencodings.cpp:102
3./src/util/strencodings.h:106
4./src/bitcoin-cli.cpp:746
5./src/net.cpp:547
6./src/netbase.cpp:189
7./src/init.cpp:1265
8./src/init.cpp:1279
We could also do a check just for -torcontrol to check if the : exists and if it doesn’t then throw an error
@laanwj @MarcoFalke what do you think?
Looks like we currently allow lookups for the -torcontrol host based on the state of -dns (default 1) (see below). If we don’t want to change that (e.g. to disallow allow hostnames, and allow only IP addresses), we’re somewhat limited in what would be considered invalid for -torcontrol. I’m thinking this gets clarified first.