[WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags #23599

1. 
   maflcko commented at 9:39 am on November 26, 2021: member

   RPCSerializationFlags has several issues:

   • It is only used in places where transactions (and blocks) are serialized to raw hex, however the name implies this should be used for any every place that serializes data. See the confusion it caused here: #17631 (review)
   • It depends on the gArgs global, blocking progress on #21005

   Fix all issues in this pull.

2. maflcko added the label Refactoring on Nov 26, 2021
3. 
   DrahtBot commented at 5:44 am on November 27, 2021: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24513 (CChainState -> Chainstate by jamesob)
   • #23319 (rpc: Return fee and prevout (utxos) to getrawtransaction by dougEfresh)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Needs rebase on Dec 8, 2021
5. maflcko force-pushed on Dec 8, 2021
6. DrahtBot removed the label Needs rebase on Dec 8, 2021
7. DrahtBot added the label Needs rebase on Dec 8, 2021
8. maflcko force-pushed on Dec 8, 2021
9. DrahtBot removed the label Needs rebase on Dec 8, 2021
10. maflcko force-pushed on Jan 2, 2022
11. maflcko force-pushed on Jan 4, 2022
12. DrahtBot added the label Needs rebase on Jan 11, 2022
13. maflcko force-pushed on Jan 11, 2022
14. DrahtBot removed the label Needs rebase on Jan 11, 2022
15. DrahtBot added the label Needs rebase on Mar 31, 2022
16. maflcko force-pushed on Mar 31, 2022
17. DrahtBot removed the label Needs rebase on Mar 31, 2022
18. DrahtBot added the label Needs rebase on Apr 6, 2022
19. maflcko force-pushed on Apr 6, 2022
20. DrahtBot removed the label Needs rebase on Apr 6, 2022
21. DrahtBot added the label Needs rebase on Apr 20, 2022
22. maflcko renamed this:
    Tidy up RPCTxSerializationFlags
    [WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags
    on Jul 22, 2022
23. maflcko marked this as a draft on Jul 22, 2022
24. maflcko force-pushed on Jul 22, 2022
25. DrahtBot removed the label Needs rebase on Jul 22, 2022
26. 
    DrahtBot commented at 4:35 pm on September 13, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

27. DrahtBot added the label Needs rebase on Sep 13, 2022
28. Pass tx_ser_flags to TxToJSON and blockToJSON 2077909645
29. Pass ArgsManager to RPCTxSerializationFlags

    Also, rename the function to clarify that it only concerns tx
    serialization flags.

    ddca261736
30. maflcko force-pushed on Sep 13, 2022
31. 
    DrahtBot commented at 0:31 am on December 13, 2022: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
32. 
    DrahtBot commented at 0:18 am on March 13, 2023: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
33. maflcko closed this on Mar 13, 2023

    ---

34. maflcko deleted the branch on Mar 13, 2023
35. bitcoin locked this on Mar 12, 2024

Contributors
maflcko DrahtBot

Labels
Refactoring Needs rebase