[WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags #23599

maflcko commented at 9:39 AM on November 26, 2021: member

RPCSerializationFlags has several issues:

It is only used in places where transactions (and blocks) are serialized to raw hex, however the name implies this should be used for any every place that serializes data. See the confusion it caused here: #17631 (review)
It depends on the gArgs global, blocking progress on #21005

Fix all issues in this pull.

maflcko added the label Refactoring on Nov 26, 2021

DrahtBot commented at 5:44 AM on November 27, 2021: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#24513 (CChainState -> Chainstate by jamesob)
#23319 (rpc: Return fee and prevout (utxos) to getrawtransaction by dougEfresh)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot cross-referenced this on Nov 27, 2021 from issue Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` etc to return the `UniValue` instead of mutating a parameter/reference by mjdietzx

DrahtBot cross-referenced this on Nov 27, 2021 from issue rpc: Return fee and prevout (utxos) to getrawtransaction by dougEfresh

DrahtBot cross-referenced this on Nov 27, 2021 from issue refactor: cleanup/followup of Remove -deprecatedrpc=addresses flag by mjdietzx

DrahtBot cross-referenced this on Nov 28, 2021 from issue rpc: getblockfrompeer by Sjors

DrahtBot cross-referenced this on Nov 30, 2021 from issue Add `src/node/` and `src/wallet/` code to `node::` and `wallet::` namespaces by ryanofsky

DrahtBot cross-referenced this on Dec 2, 2021 from issue MOVEONLY: Move wallet backup and encryption RPCs out of rpcwallet by meshcollider

DrahtBot cross-referenced this on Dec 4, 2021 from issue Split up rpcwallet by meshcollider

DrahtBot added the label Needs rebase on Dec 8, 2021

maflcko force-pushed on Dec 8, 2021

DrahtBot removed the label Needs rebase on Dec 8, 2021

DrahtBot added the label Needs rebase on Dec 8, 2021

maflcko force-pushed on Dec 8, 2021

DrahtBot removed the label Needs rebase on Dec 8, 2021

maflcko force-pushed on Jan 2, 2022

maflcko force-pushed on Jan 4, 2022

DrahtBot cross-referenced this on Jan 8, 2022 from issue refactor: Move mutable globals cleared in `::UnloadBlockIndex` to `BlockManager` by dongcarl

DrahtBot added the label Needs rebase on Jan 11, 2022

maflcko force-pushed on Jan 11, 2022

DrahtBot removed the label Needs rebase on Jan 11, 2022

DrahtBot cross-referenced this on Jan 28, 2022 from issue rest: Use query parameters to control resource loading by stickies-v

DrahtBot cross-referenced this on Mar 2, 2022 from issue blockman: Properly guard blockfile members by dongcarl

DrahtBot cross-referenced this on Mar 11, 2022 from issue CChainState -> Chainstate by jamesob

DrahtBot cross-referenced this on Mar 25, 2022 from issue refactor: followup of remove -deprecatedrpc=addresses flag by fanquake

DrahtBot cross-referenced this on Mar 31, 2022 from issue rpc: getblock/getrawtransaction/decode*/gettxout fixups by jonatack

DrahtBot added the label Needs rebase on Mar 31, 2022

maflcko force-pushed on Mar 31, 2022

DrahtBot removed the label Needs rebase on Mar 31, 2022

DrahtBot added the label Needs rebase on Apr 6, 2022

maflcko force-pushed on Apr 6, 2022

DrahtBot removed the label Needs rebase on Apr 6, 2022

DrahtBot cross-referenced this on Apr 15, 2022 from issue deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns

DrahtBot cross-referenced this on Apr 19, 2022 from issue refactor: Move and rename `pindexBestHeader`, `fHavePruned` by dongcarl

DrahtBot added the label Needs rebase on Apr 20, 2022

maflcko renamed this:
~~Tidy up RPCTxSerializationFlags~~
[WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags
on Jul 22, 2022

maflcko marked this as a draft on Jul 22, 2022

maflcko force-pushed on Jul 22, 2022

DrahtBot removed the label Needs rebase on Jul 22, 2022

DrahtBot cross-referenced this on Jul 26, 2022 from issue rpc: Faster getblock using PureBlock by maflcko

DrahtBot cross-referenced this on Jul 31, 2022 from issue rest: Extend HTTPRequest interface to support querying path (parameters) by stickies-v

DrahtBot cross-referenced this on Jul 31, 2022 from issue rest: Move format string from path-like parameter to query parameter by stickies-v

DrahtBot commented at 4:35 PM on September 13, 2022: contributor

🐙 This pull request conflicts with the target branch and needs rebase.

<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>

DrahtBot added the label Needs rebase on Sep 13, 2022

Pass tx_ser_flags to TxToJSON and blockToJSON 2077909645

Pass ArgsManager to RPCTxSerializationFlags

Also, rename the function to clarify that it only concerns tx
serialization flags.

ddca261736

maflcko force-pushed on Sep 13, 2022

DrahtBot commented at 12:31 AM on December 13, 2022: contributor

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

DrahtBot commented at 12:18 AM on March 13, 2023: contributor

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

maflcko closed this on Mar 13, 2023

maflcko deleted the branch on Mar 13, 2023

bitcoin locked this on Mar 12, 2024