Mac OS: enable optional menu bar icon (with drop-down menu, minimize-to-tray/minimize-on-close equivalents) #2360

I'm making this ticket so others know that I'm working on making the Mac OS menu-bar icon (distinct from the dock icon) an option, along with allowing "minimize-to-tray" and "minimize-on-close" to work with that. (I don't think there's a ticket open for this, but if so, just let me know. There is #1522, but it is tangential.)

https://github.com/L2G/QA/blob/master/MacOS-GUIValidation.md

Aside: I just discovered the new checklist markup. Could be useful!

Excerpt from current draft validation plan:

Window close, no minimize options

Steps

1. Start Bitcoin-Qt.
2. Open Preferences and choose "Window."
3. Ensure no checkboxes are checked/ticked.
4. Click OK.
5. Hit the window-close button on the main window.

Expect

1. The window should close.
2. Bitcoin-Qt should quit.
3. The dock should not show Bitcoin-Qt to be running (either no icon, or icon present without the "LED").

Result (choose one)

• PASS
• FAIL

Can you also post some screens, when you invent something new for Mac as this strange world is nothing I have access to ^^.

Absolutely!

In this case, happily, a lot of the code is already in place and just needs to be freed from #ifndef Q_OS_MAC blocks.

Here's what we're talking about:

This is the upper-right corner of the Mac OS desktop, what Apple calls the "status menus." It's equivalent to the system tray in Windows. As far as I can tell, all of the system-tray-related stuff in Qt goes here when built on the Mac. All I did to get to this point was remove most of the #ifndef Q_OS_MAC conditionals from the code. It will take more work than that, of course.

How is this going? Any progress?

Closing due to lack of communication, let me know if you make any progress and this needs to be reopened.