rpc: getnetworkinfo subversion has spurious trailing 0 #23615

1. 
   Sjors commented at 5:44 am on November 28, 2021: member

   Reported by @k9ert: https://github.com/cryptoadvance/specter-desktop/pull/1482#discussion_r756783512

   Confirmed on the 22.0x branch:

   0bitcoin-cli getnetworkinfo
   1{
   2  "version": 220000,
   3  "subversion": "/Satoshi:22.0.0/",
   4...
   

   cc @achow101

2. Sjors added the label Bug on Nov 28, 2021
3. fanquake deleted a comment on Nov 28, 2021
4. 
   MarcoFalke commented at 8:27 am on November 29, 2021: member

   This should be the build id, which is always displayed now for clarity?
5. MarcoFalke added the label Questions and Help on Nov 29, 2021
6. MarcoFalke removed the label Bug on Nov 29, 2021
7. MarcoFalke added the label Brainstorming on Nov 29, 2021
8. MarcoFalke added the label Build system on Nov 29, 2021
9. 
   MarcoFalke commented at 8:30 am on November 29, 2021: member

   At some point someone asked the same thing about the --version, but I can’t find the thread.

   Cf.

   0$ bitcoin-core.cli --version 
   1Bitcoin Core RPC client version v22.0.0
   

10. 
    laanwj commented at 11:32 am on November 29, 2021: member

    I’m not sure it is spurious. It’s padded to have all the potential version numbers. In the past we had four-number versions in some cases (e.g. a small platform-specific update) so wouldn’t entirely rule out an e.g. 23.0.1 with three numbers.
11. 
    Sjors commented at 1:34 pm on November 29, 2021: member

    I guess if it’s intentional then it’s not a bug. The binary archive name can always be derived from the version field instead, if you know the rules. Or we could add yet another result to this RPC like version_rounded.
12. 
    MarcoFalke commented at 1:39 pm on November 29, 2021: member

    The binary name could also be changed to include the build id?
13. 
    MarcoFalke commented at 3:42 pm on March 29, 2022: member

    @Sjors Can this be closed?
14. 
    Sjors commented at 3:57 pm on March 29, 2022: member

    I stopped caring :-)

    (I assume everyone who ran into this has implemented a workaround by now)

15. Sjors closed this on Mar 29, 2022

    ---

16. DrahtBot locked this on Mar 29, 2023

Contributors
Sjors MarcoFalke laanwj

Labels
Brainstorming Build system Questions and Help