MOVEONLY: Move helper functions from rpcwallet to wallet/rpc/util #23640

1. 
   meshcollider commented at 9:00 am on December 1, 2021: contributor

   This is part one of multiple to split up rpcwallet.cpp into smaller, more logical units.

   See #23622 for context and overall plan. I’ll open PRs in stages to hopefully minimise conflicts.

   Can be reviewed with --color-moved=dimmed-zebra

   The end goal can be seen here: https://github.com/meshcollider/bitcoin/tree/202111_split_walletrpc

2. Introduce wallet/rpc/util 7b04a064f6
3. MOVEONLY: Move utility functions from rpcwallet to wallet/rpc/util ff945e553a
4. meshcollider added the label Refactoring on Dec 1, 2021
5. meshcollider added the label Wallet on Dec 1, 2021
6. MarcoFalke approved
7. 
   MarcoFalke commented at 10:40 am on December 1, 2021: member

   nice, ACK ff945e553affbb7e25da1257a0dd47e413ec5164 🐰

   Signature:

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA512
    2
    3nice, ACK ff945e553affbb7e25da1257a0dd47e413ec5164 🐰
    4-----BEGIN PGP SIGNATURE-----
    5
    6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    7pUiYiQwArpHgRuLliC6KWPiKolqhMlTIDGxTF+1a7BrHv+8E/MgOIQJ3ZCLjM0gZ
    8Io2+wnbGNzXYD7176D7CGF5hxfv+2TEr41QG+wYpNeZO1R2Ej2oys7Ns38PluM3h
    9+tGYB2b0GYaB2yvBYueUlYblynTmJZHF5yeW8qOP4jbBHSnLy92tL/O4cxuZIOJo
   10L3YSYz1Qgu91CKsDvfNPpQwY6jNHyGBDOE2b2sK20ZgMya6Lg/9Y2ca68ZHQ9DMt
   118elCsPOzQyYtBM3f5ado0WOq+wFsI/MriS+KVd3LrRznGXplodlYD8uTl2/eVxNf
   12jL9xqcP90Nyb23UyzhZHD/7JUK8FcXyi5tJN/HbYa/CuWEinTVLYaDLIFQYFpbv7
   13KByYUEjd/4z2p7uwpjcoqSTwalH9k4CU4e9uoR0F+NflURIP/vdjZWROXbyRymb5
   14cvK+go4ewVJkhUjUKpU9vD62HorgsygGblVwVx6QhtkggBuqQ2tZHfovGOT8YjsL
   15Hoi4ZoXk
   16=GpZN
   17-----END PGP SIGNATURE-----
   

8. shaavan approved
9. 
   shaavan commented at 11:54 am on December 1, 2021: contributor

   ACK ff945e553affbb7e25da1257a0dd47e413ec5164

   This PR along with its original agenda also:

   1. Removes static and static inline keywords from the functions that were moved.
   2. Removes unnecessary imports and declarations of headers and classes. The removed headers and classes were either unused or were imported along with other imported files.
10. 
    DrahtBot commented at 1:13 pm on December 1, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #23497 (Add src/node/ and src/wallet/ code to node:: and wallet:: namespaces by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. MarcoFalke merged this on Dec 2, 2021
12. MarcoFalke closed this on Dec 2, 2021

    ---

13. sidhujag referenced this in commit 534caaae5b on Dec 2, 2021
14. meshcollider deleted the branch on Dec 3, 2021
15. RandyMcMillan referenced this in commit a020462721 on Dec 23, 2021
16. DrahtBot locked this on Dec 3, 2022

Contributors
meshcollider MarcoFalke shaavan DrahtBot

Labels
Refactoring Wallet