Write more decodescript tests #23641

1. 
   MarcoFalke commented at 9:14 am on December 1, 2021: member

   There are some test cases mentioned in #23486#issue-1051148887

   Currently they need to be manually executed with bitcoin-cli. It would be nice to integrate them into the existing decodescript functional test.

   I recommend to check the full response as opposed to just a partial response, as it is being done currently in the functional test.

   Useful skills:

   • Python3
   • Background in our functional tests
   • Basic background in our RPC interface
   • Basic bitcoin script background

   Want to work on this issue?

   For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

2. MarcoFalke added the label good first issue on Dec 1, 2021
3. 
   MarcoFalke commented at 9:14 am on December 1, 2021: member

   For reference, the test cases are:

   0./src/bitcoin-cli decodescript 5120eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee # witness_v1_taproot
   1./src/bitcoin-cli decodescript 5102eeee # witness_unknown
   2./src/bitcoin-cli decodescript 0020eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee # witness_v0_scripthash
   3./src/bitcoin-cli decodescript a914eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee87
   4./src/bitcoin-cli decodescript 6a00 # nulldata
   5./src/bitcoin-cli decodescript 6aee # nonstandard invalid opcode
   6./src/bitcoin-cli decodescript 6a02ee # nonstandard parse error
   7./src/bitcoin-cli decodescript 02eeee # nonstandard valid opcodes
   8./src/bitcoin-cli decodescript ba # nonstandard checksigadd
   9./src/bitcoin-cli decodescript 50 # nonstandard "op success"
   

4. MarcoFalke added the label Tests on Dec 1, 2021
5. MarcoFalke referenced this in commit d20d6ac545 on Dec 6, 2021
6. MarcoFalke closed this on Dec 6, 2021

   ---

7. sidhujag referenced this in commit 20b6b60d94 on Dec 6, 2021
8. DrahtBot locked this on Dec 6, 2022

Contributors
MarcoFalke

Labels
Tests good first issue