rpc: correct `getnewaddress`/`getrawchangeaddress` address_type helptext #23676

RPC calls getnewaddress/getrawchangeaddress support the address_type of bech32m but it is omitted in the RPCHelpMan help text.

The createmultisig and addmultisigaddress help text was not updated since bech32m is not yet supported in these.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #23667 (Split up rpcwallet by meshcollider)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Concept ACK

I agree with the updates done in this PR.

However, I tried to verify the following statement:

The createmultisig and addmultisigaddress help text was not updated since bech32m is not yet supported in these.

But I was not able to find any trusted material. It would help me correctly review the PR if you shared some article explaining this statement. Thank You.

@shaavan , there is exception handling in both createmultisig and addmultisigaddress that will explicitly fail the command if an address_type of bech32m is provided.

References:

• createmultisig, misc.cpp line 146
• addmultisigaddress, rpcwallet.cpp line 864

ACK 576720850467b7b21ca1ab59deab27b7a0c1c176

Thanks for the references, @brianddk.

I have checked that the changes made in this PR are correct and complete.