test: Remove false coinstatsindex test #23681

pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:stale-coinstats changing 1 files +0 −8
  1. fjahr commented at 10:01 pm on December 5, 2021: member

    This test never actually tested the behavior that it describes in the comments. This was discovered in #21590 which seems to speed up muhash which lead to the test failing.

    I can vaguely remember that the described behavior was desired by some reviewers of coinstatsindex: That coinstatsindex should be aware of stale blocks and able to return statistics on them as well. The index actually does this for blocks that it sees while the index is active, i.e. while running coinstatsindex all blocks will be indexed and even when they become stale the index (via gettxoutsetinfo) will still return a result for them when given the right hash. But this currently does not work for blocks that the node saw and that became stale before the node activated coinstatsindex. While the index syncs initially everything but the active chain is ignored and I don’t see any indication that this ever worked differently in the past.

    Introducing this behavior seems non-trivial at first glance so, while I will give this a shot, I think the test should be removed so it does not confuse users and does not block #21590.

  2. test: Remove false coinstatsindex test c055f6b216
  3. DrahtBot added the label Tests on Dec 5, 2021
  4. MarcoFalke commented at 8:56 am on December 6, 2021: member
    ack
  5. MarcoFalke merged this on Dec 6, 2021
  6. MarcoFalke closed this on Dec 6, 2021

  7. sidhujag referenced this in commit 177261cf2d on Dec 6, 2021
  8. RandyMcMillan referenced this in commit e4d19f9993 on Dec 23, 2021
  9. DrahtBot locked this on Dec 6, 2022


fjahr MarcoFalke

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me