jonatack
commented at 12:49 PM on December 7, 2021:
member
in src/node/miner to
BlockAssembler::addPackageTxs()
BlockAssembler::SkipMapTxEntry()
BlockAssembler::UpdatePackagesForAdded()
These functions have thread safety lock annotations in their declarations but are missing the corresponding run-time lock assertions in their definitions.
Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions."
MarcoFalke added the label Refactoring on Dec 7, 2021
in src/node/miner to:
- BlockAssembler::addPackageTxs()
- BlockAssembler::SkipMapTxEntry()
- BlockAssembler::UpdatePackagesForAdded()
These functions have thread safety lock annotations in
their declarations but are missing the corresponding
run-time lock assertions in their definitions.
Per doc/developer-notes.md: "Combine annotations in function
declarations with run-time asserts in function definitions."
275e9390e1
jonatack force-pushed on Dec 7, 2021
jonatack
commented at 2:02 PM on December 7, 2021:
member
Rebased on latest master following merge of CI fix #23693.
shaavan approved
shaavan
commented at 2:58 PM on December 7, 2021:
contributor
ACK275e9390e1c84ac021b3c781ee239ad9ba7b78d4. Thanks for catching and fixing this!
Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions."
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:13 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me