mining, refactor: add m_mempool.cs thread safety lock assertions #23692

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:add-missing-m_mempool-lock-assertions changing 1 files +6 −0
  1. jonatack commented at 12:49 PM on December 7, 2021: member

    in src/node/miner to

    • BlockAssembler::addPackageTxs()
    • BlockAssembler::SkipMapTxEntry()
    • BlockAssembler::UpdatePackagesForAdded()

    These functions have thread safety lock annotations in their declarations but are missing the corresponding run-time lock assertions in their definitions.

    Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions."

  2. MarcoFalke added the label Refactoring on Dec 7, 2021
  3. mining, refactor: add m_mempool.cs thread safety lock assertions
    in src/node/miner to:
    
    - BlockAssembler::addPackageTxs()
    - BlockAssembler::SkipMapTxEntry()
    - BlockAssembler::UpdatePackagesForAdded()
    
    These functions have thread safety lock annotations in
    their declarations but are missing the corresponding
    run-time lock assertions in their definitions.
    
    Per doc/developer-notes.md: "Combine annotations in function
    declarations with run-time asserts in function definitions."
    275e9390e1
  4. jonatack force-pushed on Dec 7, 2021
  5. jonatack commented at 2:02 PM on December 7, 2021: member

    Rebased on latest master following merge of CI fix #23693.

  6. shaavan approved
  7. shaavan commented at 2:58 PM on December 7, 2021: contributor

    ACK 275e9390e1c84ac021b3c781ee239ad9ba7b78d4. Thanks for catching and fixing this!

    Per doc/developer-notes.md: "Combine annotations in function declarations with run-time asserts in function definitions."

    Reference: https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#threads-and-synchronization

  8. MarcoFalke merged this on Dec 7, 2021
  9. MarcoFalke closed this on Dec 7, 2021

  10. jonatack deleted the branch on Dec 7, 2021
  11. sidhujag referenced this in commit 4ed060eb71 on Dec 7, 2021
  12. jonatack restored the branch on Dec 8, 2021
  13. RandyMcMillan referenced this in commit 6ea65b59fc on Dec 23, 2021
  14. PastaPastaPasta referenced this in commit 5b91002b21 on Apr 20, 2022
  15. jonatack deleted the branch on May 12, 2022
  16. DrahtBot locked this on May 12, 2023
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me