Revert “Fixes Bug in Transaction generation in ComplexMempool benchmark” #23693

1. 
   MarcoFalke commented at 1:28 pm on December 7, 2021: member

   Developers are reporting crashes (potentially OOM) on IRC, but I can’t reproduce. Still, revert this for now, since one developer reported the bare metal this was running on crashed.
2. Revert "Fixes Bug in Transaction generation in ComplexMempool benchmark"

   This reverts commit 29e983386b0aecf99cdb7d0e08ba6b450bed313e.

   faa185bb3a
3. MarcoFalke force-pushed on Dec 7, 2021
4. 
   hebasto commented at 1:41 pm on December 7, 2021: member

   Is it ok that this PR is not based on the master branch? I mean, a commit parent is not a merge commit.
5. MarcoFalke merged this on Dec 7, 2021
6. MarcoFalke closed this on Dec 7, 2021

   ---

7. 
   MarcoFalke commented at 1:53 pm on December 7, 2021: member

   Is it ok that this PR is not based on the master branch?

   Huh, I think it is impossible to create a pull request for a branch that isn’t based on a commit in the target branch?

8. MarcoFalke deleted the branch on Dec 7, 2021
9. 
   MarcoFalke commented at 2:07 pm on December 7, 2021: member

   I mean, a commit parent is not a merge commit.

   I don’t think we do or should require that. Would there be a reason?

10. 
    laanwj commented at 3:34 pm on December 7, 2021: member

    Thanks, tested ACK faa185bb3abe5fdaeeae14706bad9437acac6a69 Can run the bench_bitcoin again without crashing my whole computer.
11. sidhujag referenced this in commit 34daf9a0d0 on Dec 7, 2021
12. 
    jonatack commented at 5:26 pm on December 7, 2021: member

    ACK, with this change merged I can run the bench tests again locally on master.
13. RandyMcMillan referenced this in commit 15bf7c19de on Dec 23, 2021
14. PastaPastaPasta referenced this in commit 5acb703331 on Apr 7, 2022
15. PastaPastaPasta referenced this in commit 9da9f5c5bd on Apr 7, 2022
16. PastaPastaPasta referenced this in commit 06fcf75fde on Apr 7, 2022
17. PastaPastaPasta referenced this in commit 7125bfaa9c on Apr 11, 2022
18. DrahtBot locked this on Dec 7, 2022

Contributors
MarcoFalke hebasto laanwj jonatack