doc: Add missing optional to getblockfrompeer #23702

1. 
   MarcoFalke commented at 10:40 am on December 8, 2021: member

   Can be reviewed with --word-diff-regex=. --ignore-all-space
2. doc: Add missing optional to getblockfrompeer aaaa34e34d
3. 
   MarcoFalke commented at 10:41 am on December 8, 2021: member

   Needed for #23083
4. 
   Sjors commented at 11:38 am on December 8, 2021: member

   utACK aaaa34e34db6ff0f9ca3407bda42e7f0db887737
5. DrahtBot added the label RPC/REST/ZMQ on Dec 8, 2021
6. MarcoFalke merged this on Dec 8, 2021
7. MarcoFalke closed this on Dec 8, 2021

   ---

8. MarcoFalke deleted the branch on Dec 8, 2021
9. MarcoFalke added the label Docs on Dec 8, 2021
10. in src/rpc/blockchain.cpp:784 in aaaa34e34d

    795-                },
    796+    return RPCHelpMan{
    797+        "getblockfrompeer",
    798+        "\nAttempt to fetch block from a given peer.\n"
    799+        "\nWe must have the header for this block, e.g. using submitheader.\n"
    800+        "\nReturns {} if a block-request was successfully scheduled\n",
    

    ---

    ---

    

    jonatack commented at 12:33 pm on December 8, 2021:

    0-        "\nReturns {} if a block-request was successfully scheduled\n",
    1+        "\nReturns {} if a block-request was successfully scheduled.\n",
    

    ---

    

    MarcoFalke commented at 12:40 pm on December 8, 2021:

    The trailing newline isn’t needed either. Whitespace will be normalized by the doc generator.

    ---

    

    Sjors commented at 1:28 pm on December 8, 2021:

    I added the . in #23706, but I was not able to drop the trailing \n without messing up the formatting of bitcoin-cli help getblockfrompeer.

    ---

    

    MarcoFalke commented at 6:06 pm on December 8, 2021:

    Sorry, I never implemented this. Done in https://github.com/bitcoin/bitcoin/pull/23714
11. 
    jonatack commented at 12:34 pm on December 8, 2021: member

    Post-merge ACK, one nit for any follow-ups.
12. sidhujag referenced this in commit 9b29fd36ba on Dec 8, 2021
13. luke-jr referenced this in commit 03d1e73049 on Dec 14, 2021
14. RandyMcMillan referenced this in commit 897fda0730 on Dec 23, 2021
15. Fabcien referenced this in commit 93ae2058ec on Dec 3, 2022
16. DrahtBot locked this on Dec 8, 2022

Contributors
MarcoFalke Sjors jonatack

Labels
Docs RPC/REST/ZMQ