test: interface_bitcoin_cli.py: check specified wallet type availability #23712

pull theStack wants to merge 1 commits into bitcoin:master from theStack:2021-test-check-proper-wallet-in-interface_bitcoin_cli changing 1 files +9 −3
  1. theStack commented at 4:44 PM on December 8, 2021: member

    Currently the test interface_bitcoin_cli.py performs the wallet-relevant parts if any wallet type support is compiled in, independently of whether the test is run with legacy or descriptor wallet specified. This leads to a failure if the test is started with the --legacy-wallet parameter, but bitcoind is compiled without BDB support, see e.g #23686 (comment)

    Fix this by checking if the specified wallet type (BDB for legacy wallet, SQLite for descriptor wallet) is available.

    Should further pave the way for #23682.

  2. test: interface_bitcoin_cli.py: check specified wallet type availability
    Currently the test performs the wallet-relevant parts if
    _any_ wallet type support is compiled in, independently of
    whether the test is run with legacy or descriptor wallet
    specified. This leads to a failure if the test is started
    with the `--legacy-wallet` parameter, but bitcoind is
    compiled without BDB support.
    
    Fix this by checking if the specified wallet type (BDB for
    legacy wallet, SQLite for descriptor wallet) is available.
    b57bf25cfe
  3. MarcoFalke requested review from achow101 on Dec 8, 2021
  4. achow101 commented at 4:53 PM on December 8, 2021: member

    ACK b57bf25cfee3d3d0e08e5565b23e5e12ea88aee5

  5. laanwj added the label Tests on Dec 8, 2021
  6. MarcoFalke approved
  7. MarcoFalke commented at 5:29 PM on December 8, 2021: member

    thanks for the fix

  8. MarcoFalke merged this on Dec 8, 2021
  9. MarcoFalke closed this on Dec 8, 2021

  10. theStack deleted the branch on Dec 8, 2021
  11. sidhujag referenced this in commit 3e7963f64d on Dec 9, 2021
  12. RandyMcMillan referenced this in commit df325dbcc3 on Dec 23, 2021
  13. DrahtBot locked this on Dec 8, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me