test: feature_rbf.py: check specified wallet type availability #23715

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202112-test-check-feature_rbf-wallet-availability changing 3 files +9 −7

theStack commented at 7:11 PM on December 8, 2021: member

The test currently leads to a failure if in general wallet support is compiled, but the library for the specified type (BDB/SQLite) is not, i.e. if started with the --legacy-wallet parameter, but bitcoind is compiled without BDB support, see e.g. #23682 (comment)

Fix this by checking if the specified wallet type (BDB for legacy wallet, SQLite for descriptor wallet) is available.

Also move the helper is_specified_wallet_compiled() to the test framework's class BitcoinTestFramework first, so it can be reused.

Should further pave the way for #23682. On my local instance without BDB compiled, all targets in test_runner pass now.

test: feature_rbf.py: check specified wallet type availability

The test currently leads to a failure if in general wallet
support is compiled, but the library for the specified type
(BDB/SQLite) is not, i.e.  if started with the
`--legacy-wallet` parameter, but bitcoind is compiled
without BDB support.

Fix this by checking if the specified wallet type (BDB for
legacy wallet, SQLite for descriptor wallet) is available.

Also move the helper `is_specified_wallet_compiled()` to the
test framework's class BitcoinTestFramework first, so it can
be reused.

84bc35d7a5

DrahtBot added the label Tests on Dec 8, 2021
mzumsande commented at 12:23 AM on December 9, 2021: member

ACK 84bc35d7a5b91c50cb58ff844e7fc7d9f026cc76, changes loook good for me and I confirmed that this fixes the error encountered on master when running the test --without-bdb.

Should further pave the way for #23682. On my local instance without BDB compiled, all targets in test_runner pass now.

For me, feature_coinstatsindex.py still fails locally.
MarcoFalke merged this on Dec 9, 2021
MarcoFalke closed this on Dec 9, 2021
theStack deleted the branch on Dec 9, 2021
sidhujag referenced this in commit 6965bbed05 on Dec 10, 2021
RandyMcMillan referenced this in commit 51924900c5 on Dec 23, 2021
DrahtBot locked this on Dec 9, 2022

Contributors

theStack

mzumsande

Labels

Tests

Linked (view graph)

#23682 ci: Make macOS native task sqlite only