A small refactor that doesn't matter too much, but it using the named constructor is nice because:
- It clarifies that it is a built-in function
- It is (trivially) faster and less code.
test: Replace hashlib.new with named constructor #23723
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2112-testNoNew changing 1 files +4 −2-
MarcoFalke commented at 1:41 PM on December 9, 2021: member
-
test: Replace hashlib.new with named constructor fa1b63c018
-
MarcoFalke commented at 1:42 PM on December 9, 2021: member
This removes the last use of
new:git grep 'hashlib.new'. - fanquake added the label Tests on Dec 9, 2021
-
Zero-1729 commented at 1:58 PM on December 9, 2021: contributor
ACK fa1b63c01887adff83f16b1bbba3bd159dc51104
Verified no other instance of
hashlib.newafter this patch. - w0xlt approved
-
w0xlt commented at 2:12 PM on December 9, 2021: contributor
ACK fa1b63c
- MarcoFalke merged this on Dec 9, 2021
- MarcoFalke closed this on Dec 9, 2021
- sidhujag referenced this in commit 777d23670c on Dec 10, 2021
- RandyMcMillan referenced this in commit 4c68f61792 on Dec 23, 2021
- DrahtBot locked this on Dec 9, 2022
Contributors
Labels