test: fix `feature_coinstatsindex.py --descriptors` and add to test runner #23725

pull theStack wants to merge 2 commits into bitcoin:master from theStack:202112-test-fix-feature_coinstatsindex-with-descriptors changing 3 files +6 −3

theStack commented at 3:25 PM on December 9, 2021: member

The functional test feature_coinstatsindex.py currently fails on master branch, if descriptor wallets are used (argument --descriptors; or if BDB is not compiled, see #23682 (comment)). This is due to the fact that different change output types are used for created transactions (P2WPKH for legacy wallets, P2TR for descriptor wallets; the former doesn't have a ScriptPubKeyMan for bech32m), resulting in different tx sizes and hence also fees. Fix this by explicitely setting the output type via passing both -addresstype=bech32 and -changetype=bech32 as argument. The former would not be needed by now, but makes the test more deterministic and avoids a failure if bech32m becomes the default address type.

Should further pave the way for #23682.

in test/functional/feature_coinstatsindex.py:43 in 578e1ea5e8 outdated

  39 | @@ -40,7 +40,9 @@ def set_test_params(self):
  40 |          self.num_nodes = 2
  41 |          self.supports_cli = False
  42 |          self.extra_args = [
  43 | -            [],
  44 | +            # Explicitely set the output type in order to have constintent tx vsize / fees

stratospher commented at 3:35 PM on December 9, 2021:

In 578e1ea

            # Explicitly set the output type in order to have consistent tx vsize / fees

theStack commented at 3:43 PM on December 9, 2021:

Thanks for catching my sloppy wording! :zipper_mouth_face: Fixed (here and also in interface_bitcoin_cli.py where I introduced it originally).

test: fix test feature_coinstatsindex.py for descriptor wallets 50b044a88e
test: add feature_coinstatsindex.py --descriptors to test_runner.py 61fb410c0d
theStack force-pushed on Dec 9, 2021
MarcoFalke commented at 4:37 PM on December 9, 2021: member

cr ACK 61fb410c0d9bc9e5fe4e3c52b4c519d49faf15f6
MarcoFalke merged this on Dec 9, 2021
MarcoFalke closed this on Dec 9, 2021
theStack deleted the branch on Dec 9, 2021
sidhujag referenced this in commit 180d4d12dd on Dec 10, 2021
RandyMcMillan referenced this in commit 39c53817ee on Dec 23, 2021
DrahtBot locked this on Dec 9, 2022

Contributors

theStack

stratospher

MarcoFalke

Linked (view graph)

#23682 ci: Make macOS native task sqlite only