Use the imperative mood in example subject line #23728

pull tcharding wants to merge 1 commits into bitcoin:master from tcharding:contributing-patches changing 1 files +1 −1
  1. tcharding commented at 12:55 AM on December 10, 2021: contributor

    The section Committing Patches within CONTIBUTING.md contains an example commit subject line that violates rule seven of the linked guide to writing commit logs (Chris Beams famous blog post).

    We should practice what we preach, especially in examples :)

    Use the imperative mood in example commit message subject line.

  2. Use the imperative mood in example subject line
    The section `Committing Patches` contains an example commit subject line
    that violates rule seven of the linked guide to writing commit
    logs (Chris Beams famous blog post).
    
    We should practice what we preach, especially in examples :)
    
    Use the imperative mood in example commit message subject line.
    efde111615
  3. fanquake added the label Docs on Dec 10, 2021
  4. jarolrod commented at 1:34 AM on December 10, 2021: member

    ACK efde11161599deb6d98fb5773c3225d589bb14c2

    to further practice what we preach, the commit title should be prefixed with its area of focus 🥃:

    doc: use the imperative mood in example subject line
    
  5. shaavan approved
  6. shaavan commented at 6:15 AM on December 10, 2021: contributor

    ACK efde11161599deb6d98fb5773c3225d589bb14c2

    The use of imperative mood makes sense here. Nice catch, @tcharding!

    And:

    commit title should be prefixed with its area of focus :tumbler_glass:

    +1 to that!

  7. MarcoFalke merged this on Dec 10, 2021
  8. MarcoFalke closed this on Dec 10, 2021

  9. sidhujag referenced this in commit de51948696 on Dec 10, 2021
  10. RandyMcMillan referenced this in commit ca2da5e3e6 on Dec 23, 2021
  11. PastaPastaPasta referenced this in commit 4b14fc14bf on Apr 7, 2022
  12. PastaPastaPasta referenced this in commit a124efb7a8 on Apr 7, 2022
  13. PastaPastaPasta referenced this in commit 77ddf92301 on Apr 7, 2022
  14. PastaPastaPasta referenced this in commit 039357da7b on Apr 11, 2022
  15. DrahtBot locked this on Dec 10, 2022
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me