context.h
file to make the code read better
Fixed typos #23776
pull DavidRomanovizc wants to merge 3 commits into bitcoin:master from DavidRomanovizc:master changing 3 files +10 −9-
DavidRomanovizc commented at 7:23 pm on December 14, 2021: noneFixed typos in some files And also added tabs in the
-
✏️ Fix typos 0605fce549
-
✏️ Fix typos
and added tabs in namespace
-
✏️ Fix typos 46292b75cc
-
ghost commented at 7:48 pm on December 14, 2021: none
Not sure about changing
block chain
toblockchain
See #5242
All PRs that tried changing it since 2014 got NACKs
-
DrahtBot added the label Block storage on Dec 14, 2021
-
mzumsande commented at 8:11 pm on December 14, 2021: memberNACK, none of these are actual typos. Namespaces aren’t indented (https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-c),
-Wbitwise-instead-of-logical
begins with a W because that’s compiler warning syntax, and the other “typos” change the meaning to the worse, or are a matter of taste at best. -
Zero-1729 commented at 9:36 pm on December 14, 2021: contributor
NACK for the reasons expressed above.
These changes are not fixing typos.
-
fanquake closed this on Dec 14, 2021
-
DrahtBot locked this on Dec 14, 2022
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me