This adds two explanations suggested in the review of #23365, that I didn’t manage to address before that PR was merged:
doc: follow-ups from #23365 (index backwards search) #23777
pull mzumsande wants to merge 1 commits into bitcoin:master from mzumsande:202112_index_followups changing 2 files +4 −0-
mzumsande commented at 9:50 pm on December 14, 2021: member
-
DrahtBot added the label UTXO Db and Indexes on Dec 14, 2021
-
fanquake requested review from jamesob on Dec 14, 2021
-
fanquake requested review from jnewbery on Dec 14, 2021
-
fanquake added the label Docs on Dec 14, 2021
-
in src/index/base.cpp:100 in 43ccaf6fdf outdated
95@@ -96,6 +96,8 @@ bool BaseIndex::Init() 96 prune_violation = false; 97 break; 98 } 99+ // block->pprev must exist at this point, since block_to_test is chosen such that it 100+ // must be encountered when going backwards from the tip
MarcoFalke commented at 8:40 am on December 15, 2021:0 // block->pprev must exist at this point, since block_to_test is part of the chain and thus 1 // must be encountered when going backwards from the tip
mzumsande commented at 10:06 am on December 15, 2021:done, thanks -
MarcoFalke approved
-
MarcoFalke commented at 8:40 am on December 15, 2021: memberACK, left a nit (can be ignored)
-
doc: add explanations for assert in index and magic numbers in test
These were suggested in review of #23365 Co-authored-by: John Newbery <john@johnnewbery.com>
-
mzumsande force-pushed on Dec 15, 2021
-
jnewbery commented at 11:18 am on December 15, 2021: memberACK e4a8d561edf3cfb326e86c87155fed41a61e7333
-
MarcoFalke merged this on Dec 16, 2021
-
MarcoFalke closed this on Dec 16, 2021
-
sidhujag referenced this in commit 8eeb7d1aaf on Dec 16, 2021
-
mzumsande deleted the branch on Dec 16, 2021
-
Fabcien referenced this in commit f929502483 on Apr 5, 2022
-
DrahtBot locked this on Dec 16, 2022