refactor: Remove implicit-integer-sign-change suppressions in validation #23795

1. 
   MarcoFalke commented at 3:24 pm on December 16, 2021: member

   A file-wide suppression is problematic because it will wave through future violations, potentially bugs.

   Fix that by using per-statement casts.

2. MarcoFalke added the label Refactoring on Dec 16, 2021
3. MarcoFalke force-pushed on Dec 16, 2021
4. MarcoFalke force-pushed on Dec 16, 2021
5. refactor: Remove implicit-integer-sign-change suppressions in validation.cpp fadd73037e
6. MarcoFalke force-pushed on Dec 16, 2021
7. 
   MarcoFalke commented at 5:05 pm on December 16, 2021: member

   Checked on my system that with clang and gcc with -O2, the bitcoind binary doesn’t change with the commit
8. shaavan approved
9. 
   shaavan commented at 10:55 am on December 17, 2021: contributor

   ACK fadd73037e266edb844f0972e82e9213171ef214

   • Checked that appropriate typecasting is being done for variables that require it.
   • Observed no implicit-integer-sign-change warning while compiling the PR.
10. 
    MarcoFalke commented at 11:05 am on December 17, 2021: member

    Observed no implicit-integer-sign-change warning while compiling the PR.

    To clarify the warnings would only appear at runtime, so it requires to run all tests (fuzz, functional, unit, …) with sanitizers enabled. This takes quite some time, but luckily CI also does it.

11. 
    DrahtBot commented at 8:03 am on December 23, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17786 (refactor: Nuke policy/fees->mempool circular dependencies by hebasto)
    • #15606 (assumeutxo by jamesob)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. theStack approved
13. 
    theStack commented at 10:58 am on December 30, 2021: member

    Code-review ACK fadd73037e266edb844f0972e82e9213171ef214
14. MarcoFalke merged this on Jan 2, 2022
15. MarcoFalke closed this on Jan 2, 2022

    ---

16. MarcoFalke deleted the branch on Jan 2, 2022
17. sidhujag referenced this in commit d88f1928f9 on Jan 2, 2022
18. Fabcien referenced this in commit c46c56d237 on Dec 9, 2022
19. DrahtBot locked this on Jan 2, 2023

Contributors
MarcoFalke shaavan DrahtBot theStack

Labels
Refactoring