contrib: add achow101 to trusted keys #23798

achow101 commented at 7:53 PM on December 16, 2021: member

For maintaining the wallet and psbt things

contrib: add achow101 to trusted keys

For maintaining the wallet and psbt things

33b511251a

laanwj added the label Tests on Dec 16, 2021

jonatack commented at 8:05 PM on December 16, 2021: member

Concept/approach ACK

laanwj commented at 8:12 PM on December 16, 2021: member

Concept ACK. Matches the key I have:

pub   rsa4096/0x17565732E08E5E41 2015-03-05 [SC] [expires: 2022-03-05]
      152812300785C96444D3334D17565732E08E5E41

unknown approved

unknown commented at 8:18 PM on December 16, 2021: none

ACK https://github.com/bitcoin/bitcoin/pull/23798/commits/33b511251acbd0ed802a8843361c7dc8d1512008

Verified the key with https://achow101.com/contact/

0xB10C commented at 8:25 PM on December 16, 2021: member

ACK on having achow101 as wallet maintainer.

meshcollider approved

meshcollider commented at 10:35 PM on December 16, 2021: contributor

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

I've verified this key in person at previous coredevs, and achow101 is a very logical replacement in the role, now I no longer have time. Thanks for volunteering Andrew!

luke-jr commented at 3:54 AM on December 17, 2021: member

Concept ACK (but please don't remove BDB support any time soon :p)

MarcoFalke removed the label Tests on Dec 17, 2021

S3RK commented at 7:24 AM on December 17, 2021: member

ACK on achow101 being wallet maintainer

DrahtBot added the label Scripts and tools on Dec 17, 2021

MarcoFalke commented at 7:48 AM on December 17, 2021: member

ACK (but please remove BDB asap, thx)

ajtowns commented at 8:59 AM on December 17, 2021: member

Concept ACK.

Key matches key in contrib/builder-keys/keys.txt. I don't expect achow to treat BDB removal particularly differently to any other (wallet-related) PR...

darosior approved

darosior commented at 10:15 AM on December 17, 2021: member

Concept ACK 33b511251acbd0ed802a8843361c7dc8d1512008

shaavan approved

shaavan commented at 10:38 AM on December 17, 2021: contributor

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

Verified the key with: https://achow101.com/contact/

glozow commented at 11:12 AM on December 17, 2021: member

concept ACK 33b511251acbd0ed802a8843361c7dc8d1512008

michaelfolkson commented at 12:49 PM on December 17, 2021: contributor

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

(conditional on bringing BDB back as a first class citizen)

(Joke. Congrats, well deserved)

kiminuo commented at 3:03 PM on December 17, 2021: contributor

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

Congratulations.

promag commented at 3:47 PM on December 17, 2021: member

ACK

benthecarman approved

benthecarman commented at 5:09 PM on December 17, 2021: contributor

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

hebasto approved

hebasto commented at 6:42 PM on December 17, 2021: member

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

$ gpg --refresh-keys
$ gpg --list-keys 152812300785C96444D3334D17565732E08E5E41
pub   rsa4096 2015-03-05 [SC] [expires: 2022-03-05]
      152812300785C96444D3334D17565732E08E5E41
uid           [ unknown] Andrew Chow (Official New Key) <achow101@gmail.com>
uid           [ unknown] Andrew Chow <achow101@yahoo.com>
uid           [ unknown] Andrew Chow <andrew@achow101.com>
uid           [ unknown] Andrew Chow <achow101-lists@achow101.com>
uid           [ unknown] Andrew Chow <achow101-github@achow101.com>
uid           [ unknown] Andrew Chow <achow101@pm.me>
uid           [ unknown] Andrew Chow <achow101@protonmail.com>
sub   rsa4096 2015-03-05 [E] [expires: 2022-03-05]

Zero-1729 approved

Zero-1729 commented at 6:48 PM on December 17, 2021: contributor

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

Agree on having achow101 as wallet maintainer.

Verified:

$ gpg --list-keys 152812300785C96444D3334D17565732E08E5E41
pub   rsa4096 2015-03-05 [SC] [expires: 2022-03-05]
      152812300785C96444D3334D17565732E08E5E41
uid           [ unknown] Andrew Chow (Official New Key) <achow101@gmail.com>
uid           [ unknown] Andrew Chow <achow101-github@achow101.com>
uid           [ unknown] Andrew Chow <achow101-lists@achow101.com>
uid           [ unknown] Andrew Chow <andrew@achow101.com>
uid           [ unknown] Andrew Chow <achow101@yahoo.com>
uid           [ unknown] Andrew Chow <achow101@pm.me>
uid           [ unknown] Andrew Chow <achow101@protonmail.com>
sub   rsa4096 2015-03-05 [E] [expires: 2022-03-05]

jb55 commented at 11:25 PM on December 17, 2021: member

ACK 33b511251acbd0ed802a8843361c7dc8d1512008

gruve-p commented at 3:38 PM on December 19, 2021: contributor

ACK https://github.com/bitcoin/bitcoin/pull/23798/commits/33b511251acbd0ed802a8843361c7dc8d1512008

fanquake merged this on Dec 20, 2021

fanquake closed this on Dec 20, 2021

meshcollider commented at 7:09 AM on December 20, 2021: contributor

Congratulations @achow101 🎉

sipa commented at 6:54 PM on December 20, 2021: member

Posthumous ACK 33b511251acbd0ed802a8843361c7dc8d1512008. The key matches the one I have in my keyring.

DrahtBot locked this on Dec 20, 2022