mempool command has issues #2381

issue mikehearn opened this issue on March 18, 2013
  1. mikehearn commented at 10:11 PM on March 18, 2013: contributor

    This is more of a mental note to remind me to fix these things later.

    1. The mempool needs to be topologically sorted before being processed. Otherwise the Bloom filter updating logic doesn't work right - if transaction A which spends to the clients wallet is then spent again by transaction B and the mempool.queryHashes call gives them back in order B,A then the filter will match the latter and not the former.

    2. It will refuse to send more invs than MAX_INV_SZ. This is set to 50k entries so it shouldn't be an actual problem anytime soon.

    3. It does not update setInventoryKnown. If you do a mempool command at the start of a connection and then download them all, a subsequent filtered block will send you the same transactions again even though you already saw them.

    The PushInventory() call already solves these problems. It probably makes sense to re-use it.

  2. laanwj removed the label Priority Low on Dec 6, 2017
  3. laanwj closed this on Mar 6, 2018

  4. MarcoFalke locked this on Sep 8, 2021
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me