ArgsManager::GetIntArg should error on out-of-bounds value #23843

Currently, if an out-of-bounds value for the underlying int64_t type is passed to ArgsManager::GetIntArg() (e.g. -maxtipage=9999999999999999), the returned value will silently saturate (similar to the specification of strtoll()). Instead it would be better to detect this out-of-range value and throw an InitError during initialization, explicitly warning the user.

See also: #23841

Useful skills:

Basic C++

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

See also #17385 (stale)

Instead of throwing an error immediately, it would probably be good to print a deprecation message for one release.

if there is no one that are working on it, I can work on that

Concept NACK. It's a pain to specify max values exactly. It should remain valid to just set =999999999999 and not worry about the specifics.

Concept NACK. It's a pain to specify max values exactly. It should remain valid to just set =999999999999 and not worry about the specifics.

FWIW, I agree. I'll close the issue unless anyone feels differently.