test: Fix rpc_scantxoutset intermittent issue #23858

1. 
   MarcoFalke commented at 11:06 am on December 24, 2021: member

   I fail to see how this could have ever worked, since there is nothing that prevents the wallet from spending the coins in the utxo set.

   Fixes #23847

   Longer term it would be nice to remove the wallet and use MiniWallet here.

2. test: Fix rpc_scantxoutset intermittent issue fa0ac9d7e3
3. test: Fix pep8 of touched file

   Can be reviewed with --word-diff-regex=. --ignore-all-space

   fafe4dea16
4. DrahtBot added the label Tests on Dec 24, 2021
5. 
   DrahtBot commented at 6:30 pm on December 24, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23866 (test: use MiniWallet for rpc_scantxoutset.py by theStack)
   • #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. brunoerg approved
7. 
   brunoerg commented at 1:58 am on December 26, 2021: member

   tACK fafe4dea16c93ac8d5cd5eee872dfb8427d7809a

   I couldn’t reproduce the bug but tested the changes.

8. theStack approved
9. 
   theStack commented at 2:29 am on December 26, 2021: member

   Code-review ACK fafe4dea16c93ac8d5cd5eee872dfb8427d7809a

   Longer term it would be nice to remove the wallet and use MiniWallet here.

   Opened a PR #23866, with the PEP8 changes of this PR cherry-picked. It can be seen as an alternative, happy to rebase though if this gets in first (which could make sense considering that it is an obvious immediate fix to an issue and reviewing the other likely takes longer than this one).

10. 
    MarcoFalke commented at 10:07 am on December 26, 2021: member

    Going to merge this to fix the CI and to make a bugfix backport easier (if needed)
11. MarcoFalke merged this on Dec 26, 2021
12. MarcoFalke closed this on Dec 26, 2021

    ---

13. MarcoFalke deleted the branch on Dec 26, 2021
14. sidhujag referenced this in commit 61c7729799 on Dec 27, 2021
15. MarcoFalke referenced this in commit d3582f2d3b on Dec 27, 2021
16. DrahtBot locked this on Dec 26, 2022

Contributors
MarcoFalke DrahtBot brunoerg theStack

Labels
Tests