Bitcoin-Qt: ensure createTrayIconMenu() is always called on Mac #2386

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Mac_GUI changing 1 files +5 −2

Diapolo commented at 10:37 PM on March 19, 2013: none
- this should prevent GUI issues on Mac that were observed before (disappearing GUI - see #1522)
- the patch ensures, that createTrayIconMenu() is always called on Mac to process and use our MacDockIconHandler
L2G commented at 4:52 AM on March 20, 2013: contributor

I've built this in Mac OS 10.7.5, but I'm afraid I can't see any visible effect it has. I'm going to poke at it a little more, though.
Nerzahd commented at 6:27 AM on March 20, 2013: none

@L2G Do you right click on the icon? Should look like
Diapolo commented at 6:46 AM on March 20, 2013: none

@Nerzahd So you say it is working with this patch? Or was that just a screen from when it worked ^^.
Nerzahd commented at 7:00 AM on March 20, 2013: none

@Diapolo yes. it works with your patch.
Diapolo commented at 12:04 PM on March 20, 2013: none

@Nerzahd Thanks for testing :). @laanwj Seems we have a working patch now, can you review?
L2G commented at 3:12 PM on March 20, 2013: contributor

I was confused, sorry. Still learning Qt's terminology as it relates to Mac OS's terminology, so I mistakenly thought the "tray icon menu" would be associated with the menu-bar icon and not the dock icon. But since the menu-bar icon is #ifndef'd right out of the build at present, I don't know why I thought that.

Well, here, just in case someone cares whether more than one person could make it work. :smile_cat:
laanwj commented at 4:12 PM on March 22, 2013: member

ACK
BitcoinPullTester commented at 6:29 AM on March 25, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bcd1db7a88705fd32393061092be9a81c426532c for binaries and test log.
Diapolo commented at 6:40 AM on March 25, 2013: none

@laanwj Does this collide with the GUI refactoring, if no we should pull this now :).

Edit: ping ^^

Bitcoin-Qt: ensure createTrayIconMenu() is always called on Mac

- this should prevent GUI issues on Mac that were observed before (disappearing
  GUI - see #1522)
- the patch ensures, that createTrayIconMenu() is always called on Mac to
  process and use our MacDockIconHandler

5968cf5db2

BitcoinPullTester commented at 2:18 PM on March 30, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5968cf5db2a62689a341c02550eeebbf0dabd5ef for binaries and test log. This is an automated test script which runs test cases on each commit every time is updated. It, however, dies sometimes and fails to test properly, if you are waiting on a test, please check timestamps and if the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ and contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 9d8d85920a on Mar 31, 2013
laanwj merged this on Mar 31, 2013
laanwj closed this on Mar 31, 2013
laudney referenced this in commit f35ee2bd46 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

L2G

Linked (view graph)

#1522 GUI Disappearing