refactor: removed unnecessary parenthesis #23872

1. 
   giulioprocopio commented at 11:58 am on December 27, 2021: none

   Parenthesis arround bit shifting are useless, and make the code less readable. Also, shifting by 0 usually just has as main purpose consistency. Readability is far more important.
2. refactor: removed unnecessary parenthesis cfdba12b8a
3. 
   MarcoFalke commented at 12:04 pm on December 27, 2021: member

   Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

   • Time spent on review
   • Accidental introduction of bugs
   • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

   For more information about refactoring changes and stylistic cleanup, see

   • https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring
   • https://github.com/bitcoin/bitcoin/blob/master/.github/PULL_REQUEST_TEMPLATE.md
   • #15465

   Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

   Let me know if you have any questions.

4. MarcoFalke closed this on Dec 27, 2021

   ---

5. 
   MarcoFalke commented at 12:04 pm on December 27, 2021: member

   Getting started to contribute to Bitcoin Core

   Setting up your development environment

   New developers are very welcome and needed. There are a lot of open issues of any difficulty waiting to be fixed. However, before you start contributing, familiarize yourself with the Bitcoin Core build system and tests. Refer to the documentation in the repository on how to build Bitcoin Core and how to run the unit and functional tests. Once that is done, you are all set.

   If you need more help getting started, please refer to the following resources:

   • https://medium.com/@amitiu/onboarding-to-bitcoin-core-7c1a83b20365
   • https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core

   Pick something to work on

   If you are looking for useful contributions to help out with, you can

   • Search through the good first issues or the ones that are up for grabs. Some of them might no longer be applicable. So if you are interested, but unsure, you might want to leave a comment on the issue first.
   • Write tests to improve the coverage. Any kind of test is welcome and coverage information can be obtained from a relatively recent coverage report. If you are unsure, don’t hesitate to check back first.
   • Help with review and testing. There are easy ones such as the gui and rpc. However, review on any open pull request is welcome. Review will also help you understand the codebase better.
   • Help on meta projects related to Bitcoin Core, such as a high-level performance monitor.
   • Join us on irc and let us know what you are interested in.
6. DrahtBot added the label Refactoring on Dec 27, 2021
7. DrahtBot added the label UTXO Db and Indexes on Dec 27, 2021
8. giulioprocopio deleted the branch on Dec 27, 2021
9. DrahtBot locked this on Dec 27, 2022

Contributors
giulioprocopio MarcoFalke

Labels
Refactoring UTXO Db and Indexes