test: use MiniWallet for p2p_compactblocks.py #23873

1. 
   theStack commented at 1:53 pm on December 27, 2021: member

   This PR enables one more of the non-wallet functional tests (p2p_compactblocks.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in #20078.

   The wallet RPCs calls (getnewaddress/sendtoaddress) can easily be substituted by generating/sending to the MiniWallet’s internal address instead (self.generate(self.wallet, ...)/self.wallet.send_self_transfer(...)).

2. test: use MiniWallet for p2p_compactblocks.py

   This test can now be run even with the Bitcoin Core wallet disabled.

   d2efb66458
3. DrahtBot added the label Tests on Dec 27, 2021
4. josibake approved
5. 
   josibake commented at 4:06 pm on December 27, 2021: member

   ACK https://github.com/bitcoin/bitcoin/pull/23873/commits/d2efb66458e5ded38fe15216710de7036fe55244

   ran test without wallet enabled, worked as expected :tada:

6. brunoerg approved
7. 
   brunoerg commented at 5:33 pm on December 27, 2021: member

   tACK d2efb66458e5ded38fe15216710de7036fe55244

   worked without wallet!

8. 
   DrahtBot commented at 5:20 am on December 28, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23127 (tests: Use test framework utils where possible by vincenzopalazzo)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. MarcoFalke merged this on Dec 28, 2021
10. MarcoFalke closed this on Dec 28, 2021

    ---

11. theStack deleted the branch on Dec 28, 2021
12. sidhujag referenced this in commit 259836eb4e on Dec 28, 2021
13. DrahtBot locked this on Dec 28, 2022

Contributors
theStack josibake brunoerg DrahtBot

Labels
Tests