doc: testnet3 was not reset and is doing BIP30 checks again #23882

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2112-docBip30Testnet3 changing 1 files +2 −3

MarcoFalke commented at 6:04 PM on December 27, 2021: member

No description provided.
doc: testnet3 was not reset and is doing BIP30 checks again fa1a51cbc1
DrahtBot added the label Validation on Dec 27, 2021
MarcoFalke added the label Docs on Dec 27, 2021
shaavan commented at 12:18 PM on December 28, 2021: contributor

@MarcoFalke

It would be of great help if you could provide some reference, through which we can verify this statement:

testnet3 was not reset and is doing BIP30 checks again

Thank You.
MarcoFalke commented at 12:25 PM on December 28, 2021: member

You can check that testnet3 was not reset by the mentioned block count by running getblockcount and then comparing the block height. Alternatively you can insert std::cout << ( pindex->nHeight >= BIP34_IMPLIES_BIP30_LIMIT ) << std::endl; and see what is printed for the tip.
theStack approved
theStack commented at 6:08 PM on January 1, 2022: member

ACK fa1a51cbc1c50a6d3adcad5ccea4c6067f89f7d3

Verified that the testnet3 chain has a height of >= 1983702 (as of writing this, the height is 2134101) and thus was not reset. On this chain, the BIP30 check is now always executed due to the second condition on this line being true: https://github.com/bitcoin/bitcoin/blob/a1e04e10799791a728cce4430808517598c8742c/src/validation.cpp#L2020
fanquake merged this on Jan 2, 2022
fanquake closed this on Jan 2, 2022
MarcoFalke deleted the branch on Feb 20, 2022
DrahtBot locked this on Feb 20, 2023

Contributors

Labels