scripted-diff: Bump copyright headers #23903

pull DrahtBot wants to merge 2 commits into bitcoin:master from MarcoFalke:2112-drahty changing 534 files +534 −534

DrahtBot commented at 9:45 AM on December 30, 2021: member

No description provided.

scripted-diff: Bump copyright headers

-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-

Commits of previous years:
* 2020: fa0074e2d82928016a43ca408717154a1c70a4db
* 2019: aaaaad6ac95b402fe18d019d67897ced6b316ee0

faac4a980b

DrahtBot added the label Refactoring on Dec 30, 2021
DrahtBot commented at 9:50 AM on December 30, 2021: member

https://www.youtube.com/watch?v=Nysm_ErwdFE&t=217s (DINNER FOR ONE 1963.mp4)
hebasto approved
hebasto commented at 11:36 AM on December 30, 2021: member

~ACK faac4a980bb12baf6b8443a5cb8d4ecdfe5b4426~

Verified by running copyright_header.py update ./ locally and getting zero diff.
hebasto commented at 11:41 AM on December 30, 2021: member

Sorry, revoking my ACK.

~It seems we must drop the trailing slash in ./contrib/devtools/copyright_header.py update ./~

For example, see changes in src/ipc/protocol.h: copyright_header.py produces wrong changes 2021 --> 2021-2017

scripted-diff: Bump copyright headers

-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-

faea14ec2e

DrahtBot commented at 4:11 PM on December 30, 2021: member

Thanks, fixed

hebasto commented at 5:20 PM on December 30, 2021: member

Sorry @DrahtBot again.

May I suggest the following changes to this PR:

apply a fix to avoid changes like 2021 --> 2021-2017:

--- a/contrib/devtools/copyright_header.py
+++ b/contrib/devtools/copyright_header.py
@@ -371,7 +371,7 @@ def create_updated_copyright_line(line, last_git_change_year):
     space_split = after_copyright.split(' ')
     year_range = space_split[0]
     start_year, end_year = parse_year_range(year_range)
-    if end_year == last_git_change_year:
+    if end_year >= last_git_change_year:
         return line
     return (before_copyright + copyright_splitter +
             year_range_to_str(start_year, last_git_change_year) + ' ' +

add copyright headers to the following files:

build_msvc/libsecp256k1_config.h
contrib/devtools/clang-format-diff.py
contrib/devtools/symbol-check.py
contrib/guix/libexec/build.sh
contrib/guix/libexec/codesign.sh
contrib/tracing/log_raw_p2p_msgs.py
contrib/tracing/log_utxocache_flush.py
contrib/tracing/p2p_monitor.py
src/cuckoocache.h
src/test/torcontrol_tests.cpp
test/functional/test_framework/authproxy.py
test/functional/test_framework/descriptors.py
test/functional/test_framework/key.py
test/functional/test_framework/muhash.py
test/functional/test_framework/ripemd160.py
test/functional/test_framework/segwit_addr.py
test/lint/lint-files.sh
test/util/test_runner.py

and apply ./contrib/devtools/copyright_header.py update . once only

DrahtBot commented at 5:28 PM on December 30, 2021: member

Also #21139.

Closing as "up for grabs", as I won't be having time to work on this right now.
DrahtBot closed this on Dec 30, 2021
MarcoFalke deleted the branch on Dec 30, 2021
hebasto commented at 5:51 PM on December 30, 2021: member

Also #21139.

Closing as "up for grabs", as I won't be having time to work on this right now.

Ok, done in #23912.
MarcoFalke referenced this in commit 623745ca74 on Dec 31, 2021
DrahtBot locked this on Dec 30, 2022

Contributors

DrahtBot

hebasto

Labels

Refactoring

Linked (view graph)