Staging - GUI fixes for upstream #2393

r000n commented at 8:21 PM on March 20, 2013: contributor

Trivial changes, ported from Freicoin

in src/qt/bitcoingui.cpp:None in 87d0ce5dcf outdated

 470 | @@ -468,6 +471,28 @@ void BitcoinGUI::trayIconActivated(QSystemTrayIcon::ActivationReason reason)
 471 |  }
 472 |  #endif
 473 |  
 474 | +void BitcoinGUI::saveWindowGeometry()
 475 | +{
 476 | +    QSettings settings;
 477 | +    settings.setValue("winPos", pos());

Diapolo commented at 9:11 PM on March 20, 2013:

I would like to have these named nWindowPos or nWinPos and nWindowSize or nWinSize as we currently have n for numbers in the Qt settings.

r000n commented at 5:42 PM on March 21, 2013: contributor

Updated

Diapolo commented at 10:27 PM on March 21, 2013: none

I'll compile these patches tomorrow and try everything, thanks for updating :).

Diapolo commented at 7:30 AM on March 22, 2013: none

I tried them and they work, I just want to mention one more thing with the Window geometry. You are writing the setting when the destructor of BitcoinGUI is called. So when one want's to reset the Window position it is not possible to use the Options reset button, as the destructor call comes after and overwrites the cleaned settings with the modified Window position.

2 options: a) Don't use the destructor but perhaps an event filter. b) Modify the Options reset to also reset the Window position to the center of the screen to have initial defaults.

laanwj commented at 3:45 PM on March 22, 2013: member

I agree with these changes. One question though: what happens if the window coordinates in the settings get corrupted so that they are outside the screen area?

This may sounds like a weird concern, but I had this problem once with an application that started on the second monitor, which was no longer there. There was no way to get at it anymore and it took me a while to figure out what was happening.

Fix transaction fee in uBTC

Step for buttons 'up' and 'down' - 0.001. With BTC and mBTC all ok, but
0.001 uBTC is lower than minimal value (satoshi)
User should press 10 times on 'up' button to get 0.01 uBTC

afee36d379

Save & restore window size and position e11f1806b6

Show window in center of screen on first launch f688056f9d

r000n commented at 4:36 AM on March 23, 2013: contributor

In worst cases window will attached to screen corner (position corrupted) or maximized (size corrupted)

r000n commented at 5:10 AM on March 23, 2013: contributor

Window should be changed before it becomes visible. So these settings are "special" and separated from others. I'm not sure that user want reset window size when pressing on 'Reset' . For me, for example, it's will an unexpected behavior

laanwj commented at 6:49 AM on March 23, 2013: member

I agree that resetting the window position when pressing Reset is not really necessary, people can always move the window to where ever they want anyway.

It's also very hard to solve; moving saveGeometry call to another place than the destructor for example will not solve it, as long as it is still called every time the application quits.

Diapolo commented at 10:04 AM on March 23, 2013: none

ACK

BitcoinPullTester commented at 5:29 AM on March 25, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f688056f9d4958b50911933496bf1fa2e602d396 for binaries and test log.

laanwj referenced this in commit 8142ac2c18 on Mar 29, 2013

laanwj merged this on Mar 29, 2013

laanwj closed this on Mar 29, 2013

laudney referenced this in commit a90d3be0f1 on Mar 19, 2014

DrahtBot locked this on Sep 8, 2021