This is a "refactor" that shouldn't change behaviour, because the two times are most likely equal. A minimum of 5 outbound peers are needed to adjust the time. And if the time is adjusted, it will be by at most 70 minutes (DEFAULT_MAX_TIME_ADJUSTMENT). Thus, the progress estimate should differ by at most 7 blocks.
log: Remove GetAdjustedTime from IBD header progress estimation #24033
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2201-logNoNonsense changing 1 files +4 −1-
MarcoFalke commented at 12:22 PM on January 11, 2022: member
-
log: Remove GetAdjustedTime from IBD header progress estimation fac22fd36b
- MarcoFalke added the label Refactoring on Jan 11, 2022
- MarcoFalke added the label Utils/log/libs on Jan 11, 2022
-
MarcoFalke commented at 12:39 PM on January 11, 2022: member
The GUI doesn't use adjusted time either:
void ModalOverlay::UpdateHeaderSyncLabel() { int est_headers_left = bestHeaderDate.secsTo(QDateTime::currentDateTime()) / Params().GetConsensus().nPowTargetSpacing; ui->numberOfBlocksLeft->setText(tr("Unknown. Syncing Headers (%1, %2%)…").arg(bestHeaderHeight).arg(QString::number(100.0 / (bestHeaderHeight + est_headers_left) * bestHeaderHeight, 'f', 1))); } -
laanwj commented at 3:24 PM on January 13, 2022: member
Code review ACK fac22fd36b2d9f55dada31cc0da55520431b972a
- vincenzopalazzo approved
-
vincenzopalazzo commented at 8:30 AM on January 15, 2022: none
- MarcoFalke merged this on Jan 17, 2022
- MarcoFalke closed this on Jan 17, 2022
- MarcoFalke deleted the branch on Jan 17, 2022
- sidhujag referenced this in commit 8a053991b0 on Jan 18, 2022
- Fabcien referenced this in commit 1b1de7353a on Dec 19, 2022
- DrahtBot locked this on Jan 17, 2023
Contributors