Separate monotree repository for the wallet? #24045

issue maflcko openend this issue on January 12, 2022
  1. maflcko commented at 9:47 am on January 12, 2022: member

    Now that the GUI has been split up into its own monotree about 2 years ago (https://github.com/bitcoin/bitcoin/pull/19071), it could make sense to start a discussion to do the same to the wallet.

    Just like the GUI, the wallet is speaking with the node via internal interfaces. However, the wallet is still “baked into” large parts of the codebase that shouldn’t really depend on it. (E.g. the tests: #20078). Also, if people think that splitting the GUI (#19071) had negative effects, we should hold back on doing the same to the wallet and circle back.

    Other than that, the goals and considerations remain largely the same (see #19071 for details):

    • Separate issue and patch management
    • More focused review and interests
    • Maintain high quality assurance
    • The wallet is Bitcoin Core
  2. maflcko added the label Brainstorming on Jan 12, 2022
  3. maflcko added the label Wallet on Jan 12, 2022
  4. hebasto commented at 9:58 am on January 12, 2022: member
    I see a maintenance problem with the current situation. Within a GUI repo there are no @DrahtBot’s comments about conflicts with PRs in the main repo that touch both qt and non-qt code.
  5. maflcko commented at 10:01 am on January 12, 2022: member
    Good point. I’ll look into updating DrahtBot to predict cross-repo conflicts.
  6. maflcko commented at 7:00 am on October 17, 2022: member
    Closing for now
  7. maflcko closed this on Oct 17, 2022

  8. bitcoin locked this on Oct 17, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me