Uninstall icon changed from default nsis to bitcoin #24047

pull RottenCoin wants to merge 1 commits into bitcoin:master from RottenCoin:patch-1 changing 1 files +1 −1
  1. RottenCoin commented at 2:40 PM on January 12, 2022: none

    trivial

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. Uninstall icon changed from default nsis to bitcoin
    trivial
    9a7f197af2
  3. hebasto commented at 3:46 PM on January 12, 2022: member

    I think icons were distinguished on purpose.

  4. DrahtBot added the label Build system on Jan 12, 2022
  5. MarcoFalke commented at 4:09 PM on January 12, 2022: member

    Please include a motivation for this change and screenshots to illustrate it

  6. laanwj commented at 10:06 AM on January 13, 2022: member

    NACK from me, I think having a distinct icon for uninstalling makes sense.

    (this doesn't necessarily have to be the NSIS default uninstall icon, but it should be distinguishable from "launch bitcoin core")

  7. MarcoFalke commented at 1:00 PM on January 13, 2022: member

    Closing for now. Can be reopened once the feedback has been addressed

  8. MarcoFalke closed this on Jan 13, 2022

  9. DrahtBot locked this on Jan 13, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me