mempool: Run coin.IsSpent only once in a row #24102

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2201-mempoolCoinOnce changing 1 files +2 −2

MarcoFalke commented at 3:56 PM on January 19, 2022: member

Follow-up to commit 64e4963c635ec3a73a5fa3f32f6ec08e70609f60 and #23976 (review)

Run coin.IsSpent only once in a row

Follow-up to commit 64e4963c635ec3a73a5fa3f32f6ec08e70609f60

fa2bcc4e42

MarcoFalke added the label Refactoring on Jan 19, 2022
MarcoFalke renamed this:
~~Run coin.IsSpent only once in a row~~
mempool: Run coin.IsSpent only once in a row
on Jan 19, 2022
theStack approved
theStack commented at 4:34 PM on January 19, 2022: member

Code-review ACK fa2bcc4e42e7fed61727b3de4019e9702d4090ce

The condition false || expression is logically equivalent to just expression.
w0xlt approved
w0xlt commented at 6:55 PM on January 19, 2022: contributor

crACK https://github.com/bitcoin/bitcoin/pull/24102/commits/fa2bcc4e42e7fed61727b3de4019e9702d4090ce

There is no need for coin.IsSpent(), given the previous assertion.
shaavan approved
shaavan commented at 2:10 PM on January 20, 2022: contributor

Code Review ACK fa2bcc4e42e7fed61727b3de4019e9702d4090ce

The reason is nicely explained by @theStack.

The condition false || expression is logically equivalent to just expression.
brunoerg approved
brunoerg commented at 2:31 PM on January 20, 2022: member

crACK fa2bcc4e42e7fed61727b3de4019e9702d4090ce
glozow commented at 9:48 PM on January 20, 2022: member

utACK fa2bcc4e42e7fed61727b3de4019e9702d4090ce, agree the assertion is sufficient
MarcoFalke merged this on Jan 24, 2022
MarcoFalke closed this on Jan 24, 2022
MarcoFalke deleted the branch on Jan 24, 2022
sidhujag referenced this in commit 5d6fa560dc on Jan 28, 2022
Fabcien referenced this in commit 93a3ae2a01 on Nov 10, 2022
DrahtBot locked this on Jan 24, 2023

Contributors

Labels

Linked (view graph)

#23976 document and clean up MaybeUpdateMempoolForReorg