Easiest to review with colorMoved = dimmed-zebra and colorMovedWs = allow-indentation-change.
Resolves #23991
test, bugfix: fix intermittent failure in getrawtransaction_tests #24113
pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:rpc_rawtransaction-test-followups changing 1 files +23 −16-
jonatack commented at 3:13 PM on January 20, 2022: member
-
- fanquake added the label Tests on Jan 20, 2022
- jonatack force-pushed on Jan 20, 2022
- jonatack renamed this:
test, refactor: add GetTransaction() coverage, part 2
test, refactor: GetTransaction() coverage, part 2
on Jan 20, 2022 -
MarcoFalke commented at 5:14 PM on January 20, 2022: member
would it be possible to create a separate bugfix pr from the refactor pr to allow easier backporting/cherry-picking
-
DrahtBot commented at 7:57 PM on January 20, 2022: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #23319 (rpc: Return fee and prevout (utxos) to getrawtransaction by dougEfresh)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
test, bugfix: fix intermittent failure in getrawtransaction_tests 449dffc610
- jonatack renamed this:
test, refactor: GetTransaction() coverage, part 2
test, bugfix: fix intermittent failure in getrawtransaction_tests
on Jan 20, 2022 - jonatack force-pushed on Jan 20, 2022
-
jonatack commented at 8:17 PM on January 20, 2022: member
would it be possible to create a separate bugfix pr from the refactor pr to allow easier backporting/cherry-picking
Sure, done here. Will open the refactor pull afterward.
- MarcoFalke merged this on Jan 26, 2022
- MarcoFalke closed this on Jan 26, 2022
-
MarcoFalke commented at 10:09 AM on January 26, 2022: member
LGTM. Reviewed with
--ignore-all-space -U8 --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space. - jonatack deleted the branch on Jan 26, 2022
-
jonatack commented at 10:15 AM on January 26, 2022: member
--ignore-all-space -U8 --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
Much better, noted, thanks!
- sidhujag referenced this in commit 82ab7ddc4c on Jan 28, 2022
- DrahtBot locked this on Jan 26, 2023
Contributors
Labels