test: add functional test for `-maxtipage` parameter #24154

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202201-test-add_maxtipage_test changing 2 files +57 −0

theStack commented at 3:25 PM on January 25, 2022: member

This PR adds a missing test for the -maxtipage parameter which controls what is the allowed maximum tip age for leaving IBD: https://github.com/bitcoin/bitcoin/blob/792d0d8d512cf8ddca200317b74ce550c1a1a428/src/init.cpp#L540

Relevant code path in the CChainState::IsInitialBlockDownload method: https://github.com/bitcoin/bitcoin/blob/792d0d8d512cf8ddca200317b74ce550c1a1a428/src/validation.cpp#L1479-L1480

The test is pretty simple and should be self-explanatory.
test: add functional test for `-maxtipage` parameter 75656adfd2
laanwj commented at 3:35 PM on January 25, 2022: member

Concept ACK, thanks for adding a test for this.
laanwj added the label Tests on Jan 25, 2022
DrahtBot commented at 11:59 PM on January 25, 2022: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #24149 (Signing support for Miniscript Descriptors by darosior)
- #24148 (Miniscript support in Output Descriptors by darosior)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 6:35 AM on January 26, 2022: member

review ACK 75656adfd2020a059ab6bb2c8dfcd7b245feea7e
MarcoFalke merged this on Jan 26, 2022
MarcoFalke closed this on Jan 26, 2022
theStack deleted the branch on Jan 26, 2022
sidhujag referenced this in commit c9721a51a6 on Jan 28, 2022
DrahtBot locked this on Jan 26, 2023

Contributors

Labels

test: add functional test for `-maxtipage` parameter #24154

Conflicts